From mboxrd@z Thu Jan 1 00:00:00 1970 From: Alan Cox Subject: PATCH: IDE - do spin up for all platforms Date: Mon, 9 Aug 2004 10:39:02 -0400 Sender: linux-ide-owner@vger.kernel.org Message-ID: <20040809143902.GA16025@devserv.devel.redhat.com> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Return-path: Received: from mx1.redhat.com ([66.187.233.31]:36298 "EHLO mx1.redhat.com") by vger.kernel.org with ESMTP id S266684AbUHIOj4 (ORCPT ); Mon, 9 Aug 2004 10:39:56 -0400 Content-Disposition: inline List-Id: linux-ide@vger.kernel.org To: linux-ide@vger.kernel.org, akpm@osdl.org This was put in for PPC specifically and defined in the 2.4 tree to be paranoid about breaking stuff. The actual wait for hwif spin up is however perfectly correct for all drives. In the normal PC case the PC BIOS has done this but with other embedded boxes and with things like LinuxBIOS it may not have done. Thus it should always be done. --- drivers/ide/ide-probe.c~ 2004-08-09 15:36:13.109053400 +0100 +++ drivers/ide/ide-probe.c 2004-08-09 15:36:13.109053400 +0100 @@ -635,7 +635,6 @@ device_register(&hwif->gendev); } -#ifdef CONFIG_PPC static int wait_hwif_ready(ide_hwif_t *hwif) { int rc; @@ -671,7 +670,6 @@ return rc; } -#endif /* * This routine only knows how to look for drive units 0 and 1 @@ -717,7 +715,6 @@ local_irq_set(flags); -#ifdef CONFIG_PPC /* This is needed on some PPCs and a bunch of BIOS-less embedded * platforms. Typical cases are: * @@ -739,7 +736,6 @@ */ if (wait_hwif_ready(hwif)) printk(KERN_WARNING "%s: Wait for ready failed before probe !\n", hwif->name); -#endif /* CONFIG_PPC */ /* * Second drive should only exist if first drive was found,