From: Alan Cox <alan@redhat.com>
To: Jeff Garzik <jgarzik@pobox.com>
Cc: Alan Cox <alan@redhat.com>, linux-ide@vger.kernel.org, akpm@osdl.org
Subject: Re: PATCH: IDE - do spin up for all platforms
Date: Mon, 9 Aug 2004 11:25:21 -0400 [thread overview]
Message-ID: <20040809152521.GA28543@devserv.devel.redhat.com> (raw)
In-Reply-To: <411790DE.7010503@pobox.com>
On Mon, Aug 09, 2004 at 10:57:34AM -0400, Jeff Garzik wrote:
> It needs to check for "status != 0x7f" which is the standard "no device
> here" return status.
It checks for BUSY_STAT
> But worse than that, status can return 0xFF for "no hardware there", in
> which case this routine will hang the boot for 35 seconds.
It already handles the case where 0xFF is returned, has done for years
because people get this wrong and also because hardware going missing tends
to return 0xFF (eg PCMCIA cards).
So the code already does everything you comment on
0x7F will return from the wait (BUSY_STAT clear)
0xFF will return with an error
next prev parent reply other threads:[~2004-08-09 15:26 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2004-08-09 14:39 PATCH: IDE - do spin up for all platforms Alan Cox
2004-08-09 14:57 ` Jeff Garzik
2004-08-09 15:25 ` Alan Cox [this message]
2004-08-09 22:10 ` Benjamin Herrenschmidt
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20040809152521.GA28543@devserv.devel.redhat.com \
--to=alan@redhat.com \
--cc=akpm@osdl.org \
--cc=jgarzik@pobox.com \
--cc=linux-ide@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).