linux-ide.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Alan Cox <alan@redhat.com>
To: linux-ide@vger.kernel.org, linux-kernel@vger.kernel.org,
	torvalds@osdl.org
Subject: PATCH: deal with further ITE funny, fix a couple of ite8212 errors
Date: Mon, 16 Aug 2004 11:31:39 -0400	[thread overview]
Message-ID: <20040816153139.GA14715@devserv.devel.redhat.com> (raw)

Further stuff c/o Bryce the wondertester


--- drivers/ide/ide-probe.c~	2004-08-16 16:19:05.830364888 +0100
+++ drivers/ide/ide-probe.c	2004-08-16 16:19:05.831364736 +0100
@@ -784,6 +784,8 @@
 			if(strcmp(hwif->drives[0].id->model, drive->id->model) == 0 &&
 			   /* Don't do this for noprobe or non ATA */
 			   strcmp(drive->id->model, "UNKNOWN") &&
+			   /* ITE haven't got this figured out either (see the quirk code too) */
+			   !strstr(drive->id->model, "Integrated Technology Express") &&
 			   /* And beware of confused Maxtor drives that go "M0000000000" 
 			      "The SN# is garbage in the ID block..." [Eric] */
 			   strncmp(drive->id->serial_no, "M0000000000000000000", 20) && 
--- drivers/ide/pci/it8212.c~	2004-08-16 16:22:09.545435952 +0100
+++ drivers/ide/pci/it8212.c	2004-08-16 16:14:23.251323432 +0100
@@ -78,7 +78,7 @@
 
 struct it8212_dev
 {
-	int smart:1,			/* Are we in smart raid mode */
+	unsigned int smart:1,		/* Are we in smart raid mode */
 		timing10:1;		/* Rev 0x10 */
 	u8	clock_mode;		/* 0, ATA_50 or ATA_66 */
 	u8	want[2][2];		/* Mode/Pri log for master slave */
@@ -652,7 +652,7 @@
 		printk(KERN_ERR "it8212: out of memory, falling back to legacy behaviour.\n");
 		goto fallback;
 	}
-	memset(idev, 0, sizeof(*idev));
+	memset(idev, 0, sizeof(struct it8212_dev));
 	ide_set_hwifdata(hwif, idev);
 
 	hwif->remove = it8212_memfree;

                 reply	other threads:[~2004-08-16 15:31 UTC|newest]

Thread overview: [no followups] expand[flat|nested]  mbox.gz  Atom feed

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20040816153139.GA14715@devserv.devel.redhat.com \
    --to=alan@redhat.com \
    --cc=linux-ide@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=torvalds@osdl.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).