From mboxrd@z Thu Jan 1 00:00:00 1970 From: Jeremy Higdon Subject: Re: [patch][2/3] ide: add ide_hwif_t->dma_exec_cmd() Date: Mon, 13 Sep 2004 14:35:52 -0700 Sender: linux-kernel-owner@vger.kernel.org Message-ID: <20040913213552.GA95513@sgi.com> References: <200409130133.55663.bzolnier@elka.pw.edu.pl> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Return-path: Content-Disposition: inline In-Reply-To: <200409130133.55663.bzolnier@elka.pw.edu.pl> To: Bartlomiej Zolnierkiewicz Cc: linux-ide@vger.kernel.org, linux-kernel@vger.kernel.org, Mikael Starvik , Erik Jacobson List-Id: linux-ide@vger.kernel.org On Mon, Sep 13, 2004 at 01:33:55AM +0200, Bartlomiej Zolnierkiewicz wrote: > > [patch] ide: add ide_hwif_t->dma_exec_cmd() > > - split off ->dma_exec_cmd() from ->ide_dma_[read,write] functions > - choose command to execute by ->dma_exec_cmd() in higher layers > and remove ->ide_dma_[read,write] > > Some real bugs are also fixed: > - in Etrax ide.c driver REQ_DRIVE_TASKFILE requests weren't > handled properly for drive->addressing == 0 > - in trm290.c read and write commands were interchanged > - in sgiioc4.c commands weren't sent to disk devices Sgiioc4 only is used with multimedia devices. I don't think disks will work with it, even if you do send commands. jeremy