Re: NS87415 on C3K broken

[Bartlomiej Zolnierkiewicz <bzolnier@elka.pw.edu.pl>]

On Friday 17 September 2004 01:25, Grant Grundler wrote:
> > ide_setup_pci_controller()
> > 	-> ide_pci_enable()
> > 		-> pci_enable_device()
> > 
> > and ide_setup_pci_controller() is called at the beginning
> > of ide_setup_pci_device() before ->init_chipset()
> 
> Yes - I tracked the pci_enabled_device back to ide_setup_pci_controller().
> But I just realized I had another brainfart: ide_setup_pci_controller()
> is not ide_setup_pci_device(). I should stop coding late at night...

Heh.

> > > Anyway, ns87415 driver has more problems. The patch below adds
> > > "init_chipset" entry point and init_chipset_ns87415() calls
> > > pci_enable_device() and pci_set_master() before the probe.
> > > And my C3k still HPMCs. My guess is more of the code from
> > > init_hwif_ns87415() needs to be moved to init_chipset_ns87415().
> > > And possible call some special suckyio init routines.
> > > I won't be able to touch this for a few days.
> > > Anyone else on parisc-linux ml want to take a whack at this?
> ...
> > Yep, also if they are to stay please move them to ns87415.c
> > because using <linux/ide.h> outside drivers/ide is WRONG.
> 
> they? superio_ide_init_iops() or something else?

They.

> Willy mentioned that as a TODO item and it's on my list.
> But I didn't plan on touching that before the HPMC is resolved
> or the PCI resource mgt issues are resolved.

OK, thanks.