From: Nishanth Aravamudan <nacc@us.ibm.com>
To: James.Bottomley@SteelEye.com, jgarzik@pobox.com
Cc: kernel-janitors@lists.osdl.org, linux-ide@vger.kernel.org
Subject: [PATCH 2.6.9-rc2 12/16] scsi/sata_sx4: replace schedule_timeout() with msleep()/ssleep()
Date: Mon, 27 Sep 2004 11:29:37 -0700 [thread overview]
Message-ID: <20040927182937.GA1676@us.ibm.com> (raw)
Any comments would be appreciated.
Description: Use msleep()/ssleep() [as appropriate]
instead of schedule_timeout() to guarantee the task delays as
expected.
--- 2.6.9-rc2-vanilla/drivers/scsi/sata_sx4.c 2004-09-13 17:15:56.000000000 -0700
+++ 2.6.9-rc2/drivers/scsi/sata_sx4.c 2004-09-27 11:28:10.000000000 -0700
@@ -1189,8 +1189,7 @@ static unsigned int pdc20621_prog_dimm_g
error = 0;
break;
}
- set_current_state(TASK_UNINTERRUPTIBLE);
- schedule_timeout((i * 100) * HZ / 1000 + 1);
+ msleep(i * 100);
}
return error;
}
@@ -1223,8 +1222,7 @@ static unsigned int pdc20621_dimm_init(s
readl(mmio + PDC_TIME_CONTROL);
/* Wait 3 seconds */
- set_current_state(TASK_UNINTERRUPTIBLE);
- schedule_timeout(3 * HZ);
+ ssleep(3);
/*
When timer is enabled, counter is decreased every internal
reply other threads:[~2004-09-27 18:29 UTC|newest]
Thread overview: [no followups] expand[flat|nested] mbox.gz Atom feed
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20040927182937.GA1676@us.ibm.com \
--to=nacc@us.ibm.com \
--cc=James.Bottomley@SteelEye.com \
--cc=jgarzik@pobox.com \
--cc=kernel-janitors@lists.osdl.org \
--cc=linux-ide@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).