linux-ide.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Jeremy Higdon <jeremy@sgi.com>
To: Jeff Garzik <jgarzik@pobox.com>
Cc: Dave <dave.jiang@gmail.com>, linux-ide@vger.kernel.org
Subject: [PATCH 2.6.9-rc2] per-port LED control for sata_vsc
Date: Wed, 29 Sep 2004 21:25:52 -0700	[thread overview]
Message-ID: <20040930042552.GB201009@sgi.com> (raw)
In-Reply-To: <415B7D53.9020101@pobox.com>

On Wed, Sep 29, 2004 at 11:28:19PM -0400, Jeff Garzik wrote:
> 
> So maybe you or Dave could be convinced to roll that into a separate 
> patch, since we have consensus on that item?

I changed my mind.  Here's the patch.  I decided that I wanted a
big comment about this.

There may be a small offset to the latest version of this driver,
Jeff.  If it's a problem, let me know and I'll regenerate.


signed-off-by: Jeremy Higdon <jeremy@sgi.com>

===== drivers/scsi/sata_vsc.c 1.19 vs edited =====
--- 1.19/drivers/scsi/sata_vsc.c	2004-09-15 23:45:15 -07:00
+++ edited/drivers/scsi/sata_vsc.c	2004-09-29 21:12:40 -07:00
@@ -333,6 +333,14 @@
 
 	pci_set_master(pdev);
 
+	/* 
+	 * Config offset 0x98 is "Extended Control and Status Register 0"
+	 * Default value is (1 << 28).  All bits except bit 28 are reserved in
+	 * DPA mode.  If bit 28 is set, LED 0 reflects all ports' activity.
+	 * If bit 28 is clear, each port has its own LED.
+	 */
+	pci_write_config_dword(pdev, 0x98, 0);
+
 	/* FIXME: check ata_device_add return value */
 	ata_device_add(probe_ent);
 	kfree(probe_ent);

  parent reply	other threads:[~2004-09-30  4:28 UTC|newest]

Thread overview: 16+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2004-09-21 21:16 [PATCH] updates to Vitesse SATA driver Dave
2004-09-22  2:06 ` Jeremy Higdon
2004-09-22 15:59   ` Dave
2004-09-22 17:09     ` Dave
2004-09-22 20:13       ` Jeremy Higdon
2004-09-23 22:28         ` Dave
2004-09-22 20:07     ` Jeremy Higdon
2004-09-29 22:19 ` Jeff Garzik
2004-09-29 22:32   ` Dave
2004-09-30  2:34     ` Jeremy Higdon
2004-09-30  3:28       ` Jeff Garzik
2004-09-30  4:05         ` Jeremy Higdon
2004-09-30  4:25         ` Jeremy Higdon [this message]
2004-09-30 16:17         ` Dave
2004-09-30 16:51           ` Dave
2004-09-30  3:32     ` Jeff Garzik

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20040930042552.GB201009@sgi.com \
    --to=jeremy@sgi.com \
    --cc=dave.jiang@gmail.com \
    --cc=jgarzik@pobox.com \
    --cc=linux-ide@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).