From: "John W. Linville" <linville@tuxdriver.com>
To: Andy Warner <andyw@pobox.com>
Cc: linux-ide@vger.kernel.org, Jeff Garzik <jgarzik@pobox.com>
Subject: [patch libata-2.6] libata: SMART support via ATA pass-thru
Date: Thu, 30 Sep 2004 14:13:02 -0400 [thread overview]
Message-ID: <20040930141302.B14317@tuxdriver.com> (raw)
In-Reply-To: <20040928001633.A8363@florence.linkmargin.com>; from andyw@pobox.com on Tue, Sep 28, 2004 at 12:16:33AM -0500
Patch to add support for SMART to libata via the HDIO_DRIVE_CMD and
HDIO_DRIVE_TASK ioctls. These ioctls are translated to ATA pass-thru
CDBs and submitted via scsi_wait_req().
Signed-off-by: John W. Linville <linville@tuxdriver.com>
---
Obviously, this patch depends on the "T10/04-262 ATA pass thru" patch
posted on 9/28 by Andy Warner. It will likely need some rework both
when check condition is supported for ATA pass-thru and when new
revisions of T10/04-262 are released.
drivers/scsi/libata-scsi.c | 153 +++++++++++++++++++++++++++++++++++++++++++++
drivers/scsi/libata.h | 2
2 files changed, 155 insertions(+)
--- libata-2.6/drivers/scsi/libata.h.orig
+++ libata-2.6/drivers/scsi/libata.h
@@ -43,6 +43,8 @@ extern void ata_dev_select(struct ata_po
unsigned int wait, unsigned int can_sleep);
extern void ata_tf_to_host_nolock(struct ata_port *ap, struct ata_taskfile *tf);
extern void swap_buf_le16(u16 *buf, unsigned int buf_words);
+extern int ata_task_ioctl(struct scsi_device *scsidev, void __user *arg);
+extern int ata_cmd_ioctl(struct scsi_device *scsidev, void __user *arg);
/* libata-scsi.c */
--- libata-2.6/drivers/scsi/libata-scsi.c.orig
+++ libata-2.6/drivers/scsi/libata-scsi.c
@@ -29,10 +29,13 @@
#include "scsi.h"
#include <scsi/scsi_host.h>
#include <linux/libata.h>
+#include <linux/hdreg.h>
#include <asm/uaccess.h>
#include "libata.h"
+#define SECTOR_SIZE 512
+
typedef unsigned int (*ata_xlat_func_t)(struct ata_queued_cmd *qc, u8 *scsicmd);
static void ata_scsi_simulate(struct ata_port *ap, struct ata_device *dev,
struct scsi_cmnd *cmd,
@@ -70,6 +73,146 @@ int ata_std_bios_param(struct scsi_devic
return 0;
}
+/**
+ * ata_cmd_ioctl - Handler for HDIO_DRIVE_CMD ioctl
+ * @dev: Device to whom we are issuing command
+ * @arg: User provided data for issuing command
+ *
+ * LOCKING:
+ * Defined by the SCSI layer. We don't really care.
+ *
+ * RETURNS:
+ * Zero on success, negative errno on error.
+ */
+
+int ata_cmd_ioctl(struct scsi_device *scsidev, void __user *arg)
+{
+ int rc = 0;
+ u8 scsi_cmd[MAX_COMMAND_SIZE];
+ u8 args[4], *argbuf = NULL;
+ int argsize = 0;
+ struct scsi_request *sreq;
+
+ if (NULL == (void *)arg)
+ return -EINVAL;
+
+ if (copy_from_user(args, arg, sizeof(args)))
+ return -EFAULT;
+
+ sreq = scsi_allocate_request(scsidev, GFP_KERNEL);
+ if (!sreq)
+ return -EINTR;
+
+ memset(scsi_cmd, 0, sizeof(scsi_cmd));
+
+ if (args[3]) {
+ argsize = SECTOR_SIZE * args[3];
+ argbuf = kmalloc(argsize, GFP_KERNEL);
+ if (argbuf == NULL)
+ return -ENOMEM;
+
+ scsi_cmd[1] = (4 << 1); /* PIO Data-in */
+ sreq->sr_data_direction = DMA_FROM_DEVICE;
+ } else {
+ scsi_cmd[1] = (3 << 1); /* Non-data */
+ sreq->sr_data_direction = DMA_NONE;
+ }
+
+ scsi_cmd[0] = ATA_16;
+ scsi_cmd[2] = 0x1f; /* no off.line or cc, yes all registers */
+
+ scsi_cmd[4] = args[2];
+ if (args[0] == WIN_SMART) { /* hack -- ide driver does this too... */
+ scsi_cmd[6] = args[3];
+ scsi_cmd[8] = args[1];
+ scsi_cmd[10] = 0x4f;
+ scsi_cmd[12] = 0xc2;
+ } else {
+ scsi_cmd[6] = args[1];
+ }
+ scsi_cmd[14] = args[0];
+
+ /* Good values for timeout and retries? Values below
+ from scsi_ioctl_send_command() for default case... */
+ scsi_wait_req(sreq, scsi_cmd, argbuf, argsize, (10*HZ), 5);
+
+ if (sreq->sr_result) {
+ rc = -EIO;
+ goto error;
+ }
+
+ /* Need code to retrieve data from check condition? */
+
+ if ((argbuf)
+ && copy_to_user((void *)(arg + sizeof(args)), argbuf, argsize))
+ rc = -EFAULT;
+error:
+ scsi_release_request(sreq);
+
+ if (argbuf)
+ kfree(argbuf);
+
+ return rc;
+}
+
+/**
+ * ata_task_ioctl - Handler for HDIO_DRIVE_TASK ioctl
+ * @dev: Device to whom we are issuing command
+ * @arg: User provided data for issuing command
+ *
+ * LOCKING:
+ * Defined by the SCSI layer. We don't really care.
+ *
+ * RETURNS:
+ * Zero on success, negative errno on error.
+ */
+int ata_task_ioctl(struct scsi_device *scsidev, void __user *arg)
+{
+ int rc = 0;
+ u8 scsi_cmd[MAX_COMMAND_SIZE];
+ u8 args[7];
+ struct scsi_request *sreq;
+
+ if (NULL == (void *)arg)
+ return -EINVAL;
+
+ if (copy_from_user(args, arg, sizeof(args)))
+ return -EFAULT;
+
+ memset(scsi_cmd, 0, sizeof(scsi_cmd));
+ scsi_cmd[0] = ATA_16;
+ scsi_cmd[1] = (3 << 1); /* Non-data */
+ scsi_cmd[2] = 0x1f; /* no off.line or cc, yes all registers */
+ scsi_cmd[4] = args[1];
+ scsi_cmd[6] = args[2];
+ scsi_cmd[8] = args[3];
+ scsi_cmd[10] = args[4];
+ scsi_cmd[12] = args[5];
+ scsi_cmd[14] = args[0];
+
+ sreq = scsi_allocate_request(scsidev, GFP_KERNEL);
+ if (!sreq) {
+ rc = -EINTR;
+ goto error;
+ }
+
+ sreq->sr_data_direction = DMA_NONE;
+ /* Good values for timeout and retries? Values below
+ from scsi_ioctl_send_command() for default case... */
+ scsi_wait_req(sreq, scsi_cmd, NULL, 0, (10*HZ), 5);
+
+ if (sreq->sr_result) {
+ rc = -EIO;
+ goto error;
+ }
+
+ /* Need code to retrieve data from check condition? */
+
+error:
+ scsi_release_request(sreq);
+ return rc;
+}
+
int ata_scsi_ioctl(struct scsi_device *scsidev, int cmd, void __user *arg)
{
struct ata_port *ap;
@@ -99,6 +242,16 @@ int ata_scsi_ioctl(struct scsi_device *s
return -EINVAL;
return 0;
+ case HDIO_DRIVE_CMD:
+ if (!capable(CAP_SYS_ADMIN) || !capable(CAP_SYS_RAWIO))
+ return -EACCES;
+ return ata_cmd_ioctl(scsidev, arg);
+
+ case HDIO_DRIVE_TASK:
+ if (!capable(CAP_SYS_ADMIN) || !capable(CAP_SYS_RAWIO))
+ return -EACCES;
+ return ata_task_ioctl(scsidev, arg);
+
default:
rc = -EOPNOTSUPP;
break;
next prev parent reply other threads:[~2004-09-30 19:26 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2004-09-28 5:16 T10/04-262 ATA pass thru - patch Andy Warner
2004-09-28 5:39 ` Andy Warner
2004-09-29 16:49 ` John W. Linville
2004-09-29 18:19 ` Andy Warner
2004-09-29 17:12 ` John W. Linville
2004-09-29 20:44 ` Andy Warner
2004-09-29 18:29 ` Luciano A. Stertz
2004-09-29 17:20 ` John W. Linville
2004-09-29 18:32 ` Jeff Garzik
2004-09-29 19:31 ` Luciano A. Stertz
2004-09-29 19:38 ` Luciano A. Stertz
2004-09-29 18:55 ` John W. Linville
2004-10-05 18:53 ` Luciano A. Stertz
2004-10-05 19:06 ` Andy Warner
2004-10-05 22:19 ` Jeff Garzik
2004-10-05 22:37 ` Andy Warner
2004-10-05 22:41 ` Jeff Garzik
2004-10-06 6:04 ` Jens Axboe
2004-10-07 3:34 ` Jeff Garzik
2004-10-06 12:21 ` Luciano A. Stertz
2004-09-30 18:13 ` John W. Linville [this message]
2004-09-30 19:52 ` [patch libata-2.6] libata: SMART support via ATA pass-thru Jeff Garzik
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20040930141302.B14317@tuxdriver.com \
--to=linville@tuxdriver.com \
--cc=andyw@pobox.com \
--cc=jgarzik@pobox.com \
--cc=linux-ide@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).