From: Alan Cox <alan@redhat.com>
To: linux-ide@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: PATCH: minor IDE clean up I noticed
Date: Thu, 30 Sep 2004 13:54:30 -0400 [thread overview]
Message-ID: <20040930175430.GA688@devserv.devel.redhat.com> (raw)
Nowdays a drive always has a driver
diff -u --new-file --recursive --exclude-from /usr/src/exclude linux.vanilla-2.6.9rc3/drivers/ide/ide-proc.c linux-2.6.9rc3/drivers/ide/ide-proc.c
--- linux.vanilla-2.6.9rc3/drivers/ide/ide-proc.c 2004-09-30 15:35:48.169975152 +0100
+++ linux-2.6.9rc3/drivers/ide/ide-proc.c 2004-09-30 16:33:46.423200288 +0100
@@ -365,20 +365,7 @@
{
unsigned short *val = (unsigned short *) page;
- /*
- * The current code can't handle a driverless
- * identify query taskfile. Now the right fix is
- * to add a 'default' driver but that is a bit
- * more work.
- *
- * FIXME: this has to be fixed for hotswap devices
- */
-
- if(DRIVER(drive))
- err = taskfile_lib_get_identify(drive, page);
- else /* This relies on the ID changes */
- val = (unsigned short *)drive->id;
-
+ err = taskfile_lib_get_identify(drive, page);
if(!err)
{
char *out = ((char *)page) + (SECTOR_WORDS * 4);
next reply other threads:[~2004-09-30 17:54 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2004-09-30 17:54 Alan Cox [this message]
2004-09-30 18:05 ` PATCH: minor IDE clean up I noticed Bartlomiej Zolnierkiewicz
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20040930175430.GA688@devserv.devel.redhat.com \
--to=alan@redhat.com \
--cc=linux-ide@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).