* PATCH: minor IDE clean up I noticed
@ 2004-09-30 17:54 Alan Cox
2004-09-30 18:05 ` Bartlomiej Zolnierkiewicz
0 siblings, 1 reply; 2+ messages in thread
From: Alan Cox @ 2004-09-30 17:54 UTC (permalink / raw)
To: linux-ide, linux-kernel
Nowdays a drive always has a driver
diff -u --new-file --recursive --exclude-from /usr/src/exclude linux.vanilla-2.6.9rc3/drivers/ide/ide-proc.c linux-2.6.9rc3/drivers/ide/ide-proc.c
--- linux.vanilla-2.6.9rc3/drivers/ide/ide-proc.c 2004-09-30 15:35:48.169975152 +0100
+++ linux-2.6.9rc3/drivers/ide/ide-proc.c 2004-09-30 16:33:46.423200288 +0100
@@ -365,20 +365,7 @@
{
unsigned short *val = (unsigned short *) page;
- /*
- * The current code can't handle a driverless
- * identify query taskfile. Now the right fix is
- * to add a 'default' driver but that is a bit
- * more work.
- *
- * FIXME: this has to be fixed for hotswap devices
- */
-
- if(DRIVER(drive))
- err = taskfile_lib_get_identify(drive, page);
- else /* This relies on the ID changes */
- val = (unsigned short *)drive->id;
-
+ err = taskfile_lib_get_identify(drive, page);
if(!err)
{
char *out = ((char *)page) + (SECTOR_WORDS * 4);
^ permalink raw reply [flat|nested] 2+ messages in thread
* Re: PATCH: minor IDE clean up I noticed
2004-09-30 17:54 PATCH: minor IDE clean up I noticed Alan Cox
@ 2004-09-30 18:05 ` Bartlomiej Zolnierkiewicz
0 siblings, 0 replies; 2+ messages in thread
From: Bartlomiej Zolnierkiewicz @ 2004-09-30 18:05 UTC (permalink / raw)
To: Alan Cox; +Cc: linux-ide, linux-kernel
fixed 4 days ago in ide-dev-2.6 :)
On Thursday 30 September 2004 19:54, Alan Cox wrote:
> Nowdays a drive always has a driver
>
>
> diff -u --new-file --recursive --exclude-from /usr/src/exclude linux.vanilla-2.6.9rc3/drivers/ide/ide-proc.c linux-2.6.9rc3/drivers/ide/ide-proc.c
> --- linux.vanilla-2.6.9rc3/drivers/ide/ide-proc.c 2004-09-30 15:35:48.169975152 +0100
> +++ linux-2.6.9rc3/drivers/ide/ide-proc.c 2004-09-30 16:33:46.423200288 +0100
> @@ -365,20 +365,7 @@
> {
> unsigned short *val = (unsigned short *) page;
>
> - /*
> - * The current code can't handle a driverless
> - * identify query taskfile. Now the right fix is
> - * to add a 'default' driver but that is a bit
> - * more work.
> - *
> - * FIXME: this has to be fixed for hotswap devices
> - */
> -
> - if(DRIVER(drive))
> - err = taskfile_lib_get_identify(drive, page);
> - else /* This relies on the ID changes */
> - val = (unsigned short *)drive->id;
> -
> + err = taskfile_lib_get_identify(drive, page);
> if(!err)
> {
> char *out = ((char *)page) + (SECTOR_WORDS * 4);
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2004-09-30 20:39 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2004-09-30 17:54 PATCH: minor IDE clean up I noticed Alan Cox
2004-09-30 18:05 ` Bartlomiej Zolnierkiewicz
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).