linux-ide.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Alan Cox <alan@redhat.com>
To: Bartlomiej Zolnierkiewicz <bzolnier@elka.pw.edu.pl>
Cc: Alan Cox <alan@redhat.com>,
	linux-kernel@vger.kernel.org, linux-ide@vger.kernel.org
Subject: Re: PATCH: (Test) it8212 driver for 2.6.9rc3
Date: Thu, 30 Sep 2004 17:35:00 -0400	[thread overview]
Message-ID: <20040930213500.GC2175@devserv.devel.redhat.com> (raw)
In-Reply-To: <200409302245.18866.bzolnier@elka.pw.edu.pl>

On Thu, Sep 30, 2004 at 10:45:18PM +0200, Bartlomiej Zolnierkiewicz wrote:
> - merge+describe needed IDE core changes

Happily. I'm of the opinion the "ident whacking" callback isnt justified,
only one driver has a need for it and that driver can do it in the iops hook.

> - fix coding style and whitespace damage

Yeah

> - kill useless DECLARE_ITE_DEV macro

I'd prefer to keep it (there are likely to be some related devices from
the databook)

> - add __init to it8212_ide_init()

Good point - will fix


  reply	other threads:[~2004-09-30 21:35 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2004-09-30 18:45 PATCH: (Test) it8212 driver for 2.6.9rc3 Alan Cox
2004-09-30 20:18 ` Bartlomiej Zolnierkiewicz
2004-09-30 20:45   ` Bartlomiej Zolnierkiewicz
2004-09-30 21:35     ` Alan Cox [this message]
2004-09-30 22:01       ` Bartlomiej Zolnierkiewicz
2004-09-30 22:07         ` Alan Cox
2004-09-30 21:27   ` Alan Cox

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20040930213500.GC2175@devserv.devel.redhat.com \
    --to=alan@redhat.com \
    --cc=bzolnier@elka.pw.edu.pl \
    --cc=linux-ide@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).