From: Andy Warner <andyw@pobox.com>
To: Jeff Garzik <jgarzik@pobox.com>
Cc: Andy Warner <andyw@pobox.com>, linux-ide@vger.kernel.org
Subject: Re: libata - error register patch.
Date: Mon, 4 Oct 2004 16:44:30 -0500 [thread overview]
Message-ID: <20041004164430.A9775@florence.linkmargin.com> (raw)
In-Reply-To: <4161BFDD.1070509@pobox.com>; from jgarzik@pobox.com on Mon, Oct 04, 2004 at 05:25:49PM -0400
Jeff Garzik wrote:
> [...]
> I'm still thinking about this one.
>
> I need to check and see the behavior of this register, as we have a
> separate ata_chk_err() as well.
I think the existing behaviour is odd.
I can see a case for either removing any read of the error
register in ata_tf_read_xxx() and relying solely on ata_chk_err()
or going with my patch.
I can's see any case for leaving it as it is - I can find no
code that uses tf->hob_feature after calling ata_tf_read_xxx().
Looks to me like a cut and paste error from way back that got
mashed by LBA48 support.
Reads of the error register are not destructive (at least
according to the specs.)
--
andyw@pobox.com
Andy Warner Voice: (612) 801-8549 Fax: (208) 575-5634
prev parent reply other threads:[~2004-10-04 21:46 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2004-09-29 22:50 libata - error register patch Andy Warner
2004-10-04 21:25 ` Jeff Garzik
2004-10-04 21:44 ` Andy Warner [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20041004164430.A9775@florence.linkmargin.com \
--to=andyw@pobox.com \
--cc=jgarzik@pobox.com \
--cc=linux-ide@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).