From: Bartlomiej Zolnierkiewicz <bzolnier@elka.pw.edu.pl>
To: Benjamin Herrenschmidt <benh@kernel.crashing.org>
Cc: Jeff Garzik <jgarzik@pobox.com>, linux-ide@vger.kernel.org
Subject: Re: How to cleanly setup legacy IDE irq ?
Date: Tue, 5 Oct 2004 01:56:08 +0200 [thread overview]
Message-ID: <200410050156.08574.bzolnier@elka.pw.edu.pl> (raw)
In-Reply-To: <1096932367.12123.115.camel@gaston>
On Tuesday 05 October 2004 01:26, Benjamin Herrenschmidt wrote:
> On Tue, 2004-10-05 at 07:21, Bartlomiej Zolnierkiewicz wrote:
>
> > What about controllers in "half native" mode
> > (legacy IRQs but native addressing)?
>
> As far as IRQ routing is concerned, this is legacy mode, the controller
> driver should call that function. But this is not a "standard" state, so
> it would have done by the host controller driver, while the normal
> "legacy" mode is well defined by the progif bits 0x1 and 0x4 and thus
> the function for retreiving the irqs might be called by the generic ide
> pci code no ?
Yep.
> > Your proposal sounds fine but I worry that instead of crappy #ifdefs
> > it will end up having crappy switch (dev->device) statements.
>
> Whatever we will have will be entirely in the arch. It will usually end
> up beeing something like
>
> if (dev == onboard_ide_dev)
> return channel ? <chan_1_irq> : <chan_2_irq>;
> return NO_IRQ;
>
> Since there will be only one of these on board on 99% of the time.
Yep.
prev parent reply other threads:[~2004-10-04 23:55 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2004-10-01 3:51 How to cleanly setup legacy IDE irq ? Benjamin Herrenschmidt
2004-10-01 14:11 ` Bartlomiej Zolnierkiewicz
2004-10-02 4:30 ` Benjamin Herrenschmidt
2004-10-02 14:56 ` Bartlomiej Zolnierkiewicz
2004-10-03 0:33 ` Benjamin Herrenschmidt
2004-10-03 20:54 ` Bartlomiej Zolnierkiewicz
2004-10-03 23:42 ` Benjamin Herrenschmidt
2004-10-04 0:27 ` Bartlomiej Zolnierkiewicz
2004-10-04 1:05 ` Benjamin Herrenschmidt
2004-10-04 1:20 ` Benjamin Herrenschmidt
2004-10-04 21:35 ` Bartlomiej Zolnierkiewicz
2004-10-04 23:27 ` Benjamin Herrenschmidt
2004-10-04 1:27 ` Jeff Garzik
2004-10-04 1:26 ` Benjamin Herrenschmidt
2004-10-04 1:33 ` Jeff Garzik
2004-10-04 1:33 ` Benjamin Herrenschmidt
2004-10-04 21:21 ` Bartlomiej Zolnierkiewicz
2004-10-04 23:26 ` Benjamin Herrenschmidt
2004-10-04 23:56 ` Bartlomiej Zolnierkiewicz [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=200410050156.08574.bzolnier@elka.pw.edu.pl \
--to=bzolnier@elka.pw.edu.pl \
--cc=benh@kernel.crashing.org \
--cc=jgarzik@pobox.com \
--cc=linux-ide@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).