From: Jens Axboe <axboe@suse.de>
To: Jeff Garzik <jgarzik@pobox.com>
Cc: Andy Warner <andyw@pobox.com>,
"Luciano A. Stertz" <luciano@tteng.com.br>,
linux-ide@vger.kernel.org
Subject: Re: T10/04-262 ATA pass thru - patch.
Date: Wed, 6 Oct 2004 08:04:11 +0200 [thread overview]
Message-ID: <20041006060411.GC13631@suse.de> (raw)
In-Reply-To: <20041005224146.GA16514@havoc.gtf.org>
On Tue, Oct 05 2004, Jeff Garzik wrote:
> On Tue, Oct 05, 2004 at 05:37:03PM -0500, Andy Warner wrote:
> > Jeff Garzik wrote:
> > > [...]
> > > Probably you were running as root, and Luciano was not (guessing)
> >
> > Yup - but I was only doing it to get around the device
> > permissions (or so I thought.) Do people think I should
> > add ATA_16/ATA_12 to the approved list of scsi commands ?
>
> If you do, it's not that simple -- you would need to check the ATA
> command to see if it was permissible for an unpriveleged user to issue
> that specific ATA command.
>
> Otherwise, unpriveleged users could fry the hardware, or whatnot.
This is getting more and more horrible...
ATA_16/ATA_12 should be allowed for read, and there should be a filter
for tha ta opcode below that. We need the per-genhd loadable command
filter lists for that.
--
Jens Axboe
next prev parent reply other threads:[~2004-10-06 6:04 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2004-09-28 5:16 T10/04-262 ATA pass thru - patch Andy Warner
2004-09-28 5:39 ` Andy Warner
2004-09-29 16:49 ` John W. Linville
2004-09-29 18:19 ` Andy Warner
2004-09-29 17:12 ` John W. Linville
2004-09-29 20:44 ` Andy Warner
2004-09-29 18:29 ` Luciano A. Stertz
2004-09-29 17:20 ` John W. Linville
2004-09-29 18:32 ` Jeff Garzik
2004-09-29 19:31 ` Luciano A. Stertz
2004-09-29 19:38 ` Luciano A. Stertz
2004-09-29 18:55 ` John W. Linville
2004-10-05 18:53 ` Luciano A. Stertz
2004-10-05 19:06 ` Andy Warner
2004-10-05 22:19 ` Jeff Garzik
2004-10-05 22:37 ` Andy Warner
2004-10-05 22:41 ` Jeff Garzik
2004-10-06 6:04 ` Jens Axboe [this message]
2004-10-07 3:34 ` Jeff Garzik
2004-10-06 12:21 ` Luciano A. Stertz
2004-09-30 18:13 ` [patch libata-2.6] libata: SMART support via ATA pass-thru John W. Linville
2004-09-30 19:52 ` Jeff Garzik
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20041006060411.GC13631@suse.de \
--to=axboe@suse.de \
--cc=andyw@pobox.com \
--cc=jgarzik@pobox.com \
--cc=linux-ide@vger.kernel.org \
--cc=luciano@tteng.com.br \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).