Re: libata & scsi rescan.

[Andy Warner <andyw@pobox.com>]

Jeff Garzik wrote:
> [...]
> > If they need to be called from a helper-thread, I can do
> > that - just looking for ground rules.
> 
> Correct, they must be called from process context.

Thanks for the confirmation - I can take it from there..
Does anyone have any opinions/advice about reusing existing
helper tasks ?

Also - I need help from someone with access to Promise
chip manuals. I have Silicon Image docs, and am able
to enable interrupts on PHY status changes by setting
the correct bit in the SEIN register(s). This patchette
shows what I do:

===== drivers/scsi/sata_sil.c 1.35 vs edited =====
--- 1.35/drivers/scsi/sata_sil.c	2004-09-16 01:45:15 -05:00
+++ edited/drivers/scsi/sata_sil.c	2004-10-06 21:20:42 -05:00
@@ -415,9 +415,10 @@
 	}
 
 	/* mask all SATA phy-related interrupts */
-	/* TODO: unmask bit 6 (SError N bit) for hotplug */
-	for (i = 0; i < probe_ent->n_ports; i++)
-		writel(0, mmio_base + sil_port[i].sien);
+	/* except (SError N bit) for hotplug */
+	for (i = 0; i < probe_ent->n_ports; i++) {
+		writel(SCR_DIAG_N, mmio_base + sil_port[i].sien);
+	}
 
 	pci_set_master(pdev);
 
[NOTE: SCR_DIAG_N is (1 << 16)]

If anyone can provide me with either the promise Tx2/4 docs,
or a corresponding patch for sata_promise.c, I'd be most
grateful.

The handling of the SATA error/status registers is all
standardised, and taken care of by me. I just need to
enable SATA PHY interrupts from the promise chips.

I can only test with SiI/Promise right now, I have Marvell
and 3124 hardware, but libata drivers for them are not
available yet (*please* correct me if I'm wrong.)
For anyone with access to the right docs, adding matching
functionality to sata_vsc.c etc will be trivial once I
get past calling scsi_add/remove_device() correctly.
-- 
andyw@pobox.com

Andy Warner		Voice: (612) 801-8549	Fax: (208) 575-5634