From: Bartlomiej Zolnierkiewicz <bzolnier@elka.pw.edu.pl>
To: Alan Cox <alan@lxorguk.ukuu.org.uk>
Cc: linux-ide@vger.kernel.org
Subject: Re: PATCH: Put the new API functions in the header files
Date: Fri, 5 Nov 2004 23:02:50 +0100 [thread overview]
Message-ID: <200411052302.50280.bzolnier@elka.pw.edu.pl> (raw)
In-Reply-To: <1099672368.5630.47.camel@localhost.localdomain>
* there is no ordering of your patches
* they are splitted on file boundary not change boundary
(ie. appling one patch leaves you with kernel which won't compile)
* they are whitespace damaged as usual
:/
On Friday 05 November 2004 17:32, Alan Cox wrote:
> diff --exclude-from /usr/src/exclude -u --new-file --recursive linux.vanilla-2.6.10rc1/include/linux/ide.h linux-2.6.10rc1/include/linux/ide.h
> --- linux.vanilla-2.6.10rc1/include/linux/ide.h 2004-11-05 15:42:18.000000000 +0000
> +++ linux-2.6.10rc1/include/linux/ide.h 2004-11-05 16:26:18.000000000 +0000
> @@ -266,6 +266,7 @@
> * Register new hardware with ide
> */
> int ide_register_hw(hw_regs_t *hw, struct hwif_s **hwifp);
> +int ide_register_hw_with_fixup(hw_regs_t *hw, struct hwif_s **hwifp, void (*fixup)(struct hwif_s *));
>
> /*
> * Set up hw_regs_t structure before calling ide_register_hw (optional)
> @@ -1470,6 +1475,7 @@
> void (*init_iops)(ide_hwif_t *);
> void (*init_hwif)(ide_hwif_t *);
> void (*init_dma)(ide_hwif_t *, unsigned long);
> + void (*fixup)(ide_hwif_t *);
> u8 channels;
> u8 autodma;
> ide_pci_enablebit_t enablebits[2];
> @@ -1529,6 +1535,8 @@
> extern void ide_unregister (unsigned int index);
>
> extern int probe_hwif_init(ide_hwif_t *);
> +extern int probe_hwif_init_with_fixup(ide_hwif_t *hwif, void (*fixup)(ide_hwif_t *hwif));
> +extern void ide_undecoded_slave(ide_hwif_t *hwif);
>
> static inline void *ide_get_hwifdata (ide_hwif_t * hwif)
> {
>
>
next prev parent reply other threads:[~2004-11-05 21:59 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2004-11-05 16:32 PATCH: Put the new API functions in the header files Alan Cox
2004-11-05 22:02 ` Bartlomiej Zolnierkiewicz [this message]
2004-11-05 23:36 ` Alan Cox
2004-11-06 0:51 ` Bartlomiej Zolnierkiewicz
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=200411052302.50280.bzolnier@elka.pw.edu.pl \
--to=bzolnier@elka.pw.edu.pl \
--cc=alan@lxorguk.ukuu.org.uk \
--cc=linux-ide@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox