* [PATCH]: resubmitted: Fix erroneous rq->buffer = NULL in ide-io.c:ide_dma_timeout_retry
@ 2005-01-06 15:21 Prarit Bhargava
2005-01-06 15:55 ` Jens Axboe
0 siblings, 1 reply; 3+ messages in thread
From: Prarit Bhargava @ 2005-01-06 15:21 UTC (permalink / raw)
To: linux-ide
Colleagues,
Please see discussion related to this patch here,
http://marc.theaimsgroup.com/?l=linux-ide&m=110485007824374&w=2
Thanks,
Prarit.
--- linux-2.5.orig/drivers/ide/ide-io.c 2005-01-04 15:45:17.000000000 -0500
+++ linux-2.5/drivers/ide/ide-io.c 2005-01-04 15:45:27.000000000 -0500
@@ -1205,21 +1205,21 @@
HWGROUP(drive)->rq = NULL;
rq->errors = 0;
if (!rq->bio)
goto out;
rq->sector = rq->bio->bi_sector;
rq->current_nr_sectors = bio_iovec(rq->bio)->bv_len >> 9;
rq->hard_cur_sectors = rq->current_nr_sectors;
- rq->buffer = NULL;
+ rq->buffer = bio_data(rq->bio);
out:
return ret;
}
/**
* ide_timer_expiry - handle lack of an IDE interrupt
* @data: timer callback magic (hwgroup)
*
* An IDE command has timed out before the expected drive return
* occurred. At this point we attempt to clean up the current
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH]: resubmitted: Fix erroneous rq->buffer = NULL in ide-io.c:ide_dma_timeout_retry
2005-01-06 15:21 [PATCH]: resubmitted: Fix erroneous rq->buffer = NULL in ide-io.c:ide_dma_timeout_retry Prarit Bhargava
@ 2005-01-06 15:55 ` Jens Axboe
2005-01-07 2:18 ` Bartlomiej Zolnierkiewicz
0 siblings, 1 reply; 3+ messages in thread
From: Jens Axboe @ 2005-01-06 15:55 UTC (permalink / raw)
To: Prarit Bhargava; +Cc: linux-ide
On Thu, Jan 06 2005, Prarit Bhargava wrote:
> Colleagues,
>
> Please see discussion related to this patch here,
>
> http://marc.theaimsgroup.com/?l=linux-ide&m=110485007824374&w=2
Acked-by: Jens Axboe <axboe@suse.de>
> Thanks,
>
> Prarit.
>
>
> --- linux-2.5.orig/drivers/ide/ide-io.c 2005-01-04 15:45:17.000000000 -0500
> +++ linux-2.5/drivers/ide/ide-io.c 2005-01-04 15:45:27.000000000 -0500
> @@ -1205,21 +1205,21 @@
> HWGROUP(drive)->rq = NULL;
>
> rq->errors = 0;
>
> if (!rq->bio)
> goto out;
>
> rq->sector = rq->bio->bi_sector;
> rq->current_nr_sectors = bio_iovec(rq->bio)->bv_len >> 9;
> rq->hard_cur_sectors = rq->current_nr_sectors;
> - rq->buffer = NULL;
> + rq->buffer = bio_data(rq->bio);
> out:
> return ret;
> }
>
> /**
> * ide_timer_expiry - handle lack of an IDE interrupt
> * @data: timer callback magic (hwgroup)
> *
> * An IDE command has timed out before the expected drive return
> * occurred. At this point we attempt to clean up the current
>
>
>
> -
> To unsubscribe from this list: send the line "unsubscribe linux-ide" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at http://vger.kernel.org/majordomo-info.html
>
--
Jens Axboe
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH]: resubmitted: Fix erroneous rq->buffer = NULL in ide-io.c:ide_dma_timeout_retry
2005-01-06 15:55 ` Jens Axboe
@ 2005-01-07 2:18 ` Bartlomiej Zolnierkiewicz
0 siblings, 0 replies; 3+ messages in thread
From: Bartlomiej Zolnierkiewicz @ 2005-01-07 2:18 UTC (permalink / raw)
To: Jens Axboe; +Cc: Prarit Bhargava, linux-ide
On Thu, 6 Jan 2005 16:55:56 +0100, Jens Axboe <axboe@suse.de> wrote:
> On Thu, Jan 06 2005, Prarit Bhargava wrote:
> > Colleagues,
> >
> > Please see discussion related to this patch here,
> >
> > http://marc.theaimsgroup.com/?l=linux-ide&m=110485007824374&w=2
>
> Acked-by: Jens Axboe <axboe@suse.de>
applied
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2005-01-07 2:18 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2005-01-06 15:21 [PATCH]: resubmitted: Fix erroneous rq->buffer = NULL in ide-io.c:ide_dma_timeout_retry Prarit Bhargava
2005-01-06 15:55 ` Jens Axboe
2005-01-07 2:18 ` Bartlomiej Zolnierkiewicz
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).