From mboxrd@z Thu Jan 1 00:00:00 1970 From: Tejun Heo Subject: Re: [PATCH 2.6.11-rc2 14/29] ide: remove NULL checking in ide_error() Date: Wed, 2 Feb 2005 11:57:28 +0900 Message-ID: <20050202025728.GO621@htj.dyndns.org> References: <20050202024017.GA621@htj.dyndns.org> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20050202024017.GA621@htj.dyndns.org> Sender: linux-kernel-owner@vger.kernel.org To: B.Zolnierkiewicz@elka.pw.edu.pl, linux-kernel@vger.kernel.org, linux-ide@vger.kernel.org List-Id: linux-ide@vger.kernel.org > 14_ide_error_remove_NULL_test.patch > > In ide_error(), drive cannot be NULL. ide_dump_status() can't > handle NULL drive. Index: linux-ide-export/drivers/ide/ide-io.c =================================================================== --- linux-ide-export.orig/drivers/ide/ide-io.c 2005-02-02 10:28:04.465321080 +0900 +++ linux-ide-export/drivers/ide/ide-io.c 2005-02-02 10:28:04.904249864 +0900 @@ -555,7 +555,7 @@ ide_startstop_t ide_error (ide_drive_t * err = ide_dump_status(drive, msg, stat); - if (drive == NULL || (rq = HWGROUP(drive)->rq) == NULL) + if ((rq = HWGROUP(drive)->rq) == NULL) return ide_stopped; /* retry only "normal" I/O: */