linux-ide.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: "John W. Linville" <linville@tuxdriver.com>
To: Jens Axboe <axboe@suse.de>
Cc: linux-kernel@vger.kernel.org, linux-ide@vger.kernel.org,
	andyw@pobox.com, jgarzik@pobox.com, Curtis.Stevens@WDC.com
Subject: Re: [patch libata-dev-2.6 1/1] libata: sync SMART ioctls with ATA pass thru spec (T10/04-262r7)
Date: Wed, 2 Feb 2005 13:59:22 -0500	[thread overview]
Message-ID: <20050202185922.GD17450@tuxdriver.com> (raw)
In-Reply-To: <20050202185121.GX11484@suse.de>

On Wed, Feb 02, 2005 at 07:51:22PM +0100, Jens Axboe wrote:
> On Wed, Feb 02 2005, John W. Linville wrote:

> > -/* Temporary values for T10/04-262 until official values are allocated */
> > -#define	ATA_16		      0x85	/* 16-byte pass-thru [0x85 == unused]*/
> > -#define	ATA_12		      0xb3	/* 12-byte pass-thru [0xb3 == obsolete set limits command] */
> > +/* Values for T10/04-262r7 */
> > +#define	ATA_16		      0x85	/* 16-byte pass-thru */
> > +#define	ATA_12		      0xa1	/* 12-byte pass-thru */
> 
> Ehh are you sure that is correct? 0xa1 is the BLANK command, I would
> hate to think there would be a collision like that.

Well, I'm sure that is what is in T10/04-262r7 in Table 1 on Page 1.
The spec is available here:

	http://www.t10.org/ftp/t10/document.04/04-262r7.pdf

Previous versions of the spec did not specify a value.  As to whether
or not the current spec is in error, hopefully Curtis can elablorate?

John
-- 
John W. Linville
linville@tuxdriver.com

  reply	other threads:[~2005-02-02 18:59 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2005-02-02 18:37 [patch libata-dev-2.6 1/1] libata: sync SMART ioctls with ATA pass thru spec (T10/04-262r7) John W. Linville
2005-02-02 18:51 ` Jens Axboe
2005-02-02 18:59   ` John W. Linville [this message]
  -- strict thread matches above, loose matches on Subject: below --
2005-02-02 23:05 Douglas Gilbert
2005-02-02 23:36 ` Jeff Garzik

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20050202185922.GD17450@tuxdriver.com \
    --to=linville@tuxdriver.com \
    --cc=Curtis.Stevens@WDC.com \
    --cc=andyw@pobox.com \
    --cc=axboe@suse.de \
    --cc=jgarzik@pobox.com \
    --cc=linux-ide@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).