linux-ide.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
* [RFC: 2.6 patch] IDE: unsexport 3 functions
@ 2005-02-05  2:44 Adrian Bunk
  2005-02-06 13:25 ` Bartlomiej Zolnierkiewicz
  0 siblings, 1 reply; 3+ messages in thread
From: Adrian Bunk @ 2005-02-05  2:44 UTC (permalink / raw)
  To: B.Zolnierkiewicz; +Cc: linux-kernel, linux-ide

The patch removes three unneeded EXPORT_SYMBOL's.

Signed-off-by: Adrian Bunk <bunk@stusta.de>

---

 drivers/ide/ide-iops.c     |    4 ----
 drivers/ide/ide-taskfile.c |    2 --
 2 files changed, 6 deletions(-)

--- linux-2.6.11-rc3-mm1-full/drivers/ide/ide-iops.c.old	2005-02-05 02:54:15.000000000 +0100
+++ linux-2.6.11-rc3-mm1-full/drivers/ide/ide-iops.c	2005-02-05 02:55:21.000000000 +0100
@@ -104,8 +104,6 @@
 	hwif->INSL	= ide_insl;
 }
 
-EXPORT_SYMBOL(default_hwif_iops);
-
 /*
  *	MMIO operations, typically used for SATA controllers
  */
@@ -329,8 +327,6 @@
 	hwif->atapi_output_bytes	= atapi_output_bytes;
 }
 
-EXPORT_SYMBOL(default_hwif_transport);
-
 /*
  * Beginning of Taskfile OPCODE Library and feature sets.
  */
--- linux-2.6.11-rc3-mm1-full/drivers/ide/ide-taskfile.c.old	2005-02-05 02:57:03.000000000 +0100
+++ linux-2.6.11-rc3-mm1-full/drivers/ide/ide-taskfile.c	2005-02-05 02:57:12.000000000 +0100
@@ -161,8 +161,6 @@
 	return ide_stopped;
 }
 
-EXPORT_SYMBOL(do_rw_taskfile);
-
 /*
  * set_multmode_intr() is invoked on completion of a WIN_SETMULT cmd.
  */


^ permalink raw reply	[flat|nested] 3+ messages in thread

* Re: [RFC: 2.6 patch] IDE: unsexport 3 functions
  2005-02-05  2:44 [RFC: 2.6 patch] IDE: unsexport 3 functions Adrian Bunk
@ 2005-02-06 13:25 ` Bartlomiej Zolnierkiewicz
  2005-02-06 13:32   ` Adrian Bunk
  0 siblings, 1 reply; 3+ messages in thread
From: Bartlomiej Zolnierkiewicz @ 2005-02-06 13:25 UTC (permalink / raw)
  To: Adrian Bunk; +Cc: linux-kernel, linux-ide

> @@ -161,8 +161,6 @@
>         return ide_stopped;
>  }
> 
> -EXPORT_SYMBOL(do_rw_taskfile);
> -

Is this patch against -mm or ide-dev-2.6?

do_rw_taskfile() is still needed for ide-disk.c in linus' tree,
the other two exports can be removed

^ permalink raw reply	[flat|nested] 3+ messages in thread

* Re: [RFC: 2.6 patch] IDE: unsexport 3 functions
  2005-02-06 13:25 ` Bartlomiej Zolnierkiewicz
@ 2005-02-06 13:32   ` Adrian Bunk
  0 siblings, 0 replies; 3+ messages in thread
From: Adrian Bunk @ 2005-02-06 13:32 UTC (permalink / raw)
  To: Bartlomiej Zolnierkiewicz; +Cc: linux-kernel, linux-ide

On Sun, Feb 06, 2005 at 02:25:32PM +0100, Bartlomiej Zolnierkiewicz wrote:
> > @@ -161,8 +161,6 @@
> >         return ide_stopped;
> >  }
> > 
> > -EXPORT_SYMBOL(do_rw_taskfile);
> > -
> 
> Is this patch against -mm or ide-dev-2.6?

This is against -mm.
But the only changes regarding do_rw_taskfile in -mm come from 
bk-ide-dev.

> do_rw_taskfile() is still needed for ide-disk.c in linus' tree,
> the other two exports can be removed

cu
Adrian

-- 

       "Is there not promise of rain?" Ling Tan asked suddenly out
        of the darkness. There had been need of rain for many days.
       "Only a promise," Lao Er said.
                                       Pearl S. Buck - Dragon Seed


^ permalink raw reply	[flat|nested] 3+ messages in thread

end of thread, other threads:[~2005-02-06 13:32 UTC | newest]

Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2005-02-05  2:44 [RFC: 2.6 patch] IDE: unsexport 3 functions Adrian Bunk
2005-02-06 13:25 ` Bartlomiej Zolnierkiewicz
2005-02-06 13:32   ` Adrian Bunk

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).