From: "John W. Linville" <linville@tuxdriver.com>
To: linux-ide@vger.kernel.org, linux-kernel@vger.kernel.org,
jgarzik@pobox.com
Subject: [patch libata-dev-2.6 2/5] libata: sync SMART ioctls with ATA pass thru spec (T10/04-262r7)
Date: Fri, 18 Feb 2005 14:55:12 -0500 [thread overview]
Message-ID: <20050218195512.GC3197@tuxdriver.com> (raw)
In-Reply-To: <20050218195027.GB3197@tuxdriver.com>
Minor modifications to the SMART-related ioctls in libata, in
compliance with the latest ATA pass thru spec (T10/04-262r7).
Signed-off-by: John W. Linville <linville@tuxdriver.com>
---
drivers/scsi/libata-scsi.c | 6 ++++--
1 files changed, 4 insertions(+), 2 deletions(-)
--- sata-smart-2.6/drivers/scsi/libata-scsi.c.orig 2005-02-01 16:24:01.687622085 -0500
+++ sata-smart-2.6/drivers/scsi/libata-scsi.c 2005-02-01 16:49:18.213876086 -0500
@@ -109,14 +109,16 @@ int ata_cmd_ioctl(struct scsi_device *sc
return -ENOMEM;
scsi_cmd[1] = (4 << 1); /* PIO Data-in */
+ scsi_cmd[2] = 0x0e; /* no off.line or cc, read from dev,
+ block count in sector count field */
sreq->sr_data_direction = DMA_FROM_DEVICE;
} else {
scsi_cmd[1] = (3 << 1); /* Non-data */
+ /* scsi_cmd[2] is already 0 -- no off.line, cc, or data xfer */
sreq->sr_data_direction = DMA_NONE;
}
scsi_cmd[0] = ATA_16;
- scsi_cmd[2] = 0x1f; /* no off.line or cc, yes all registers */
scsi_cmd[4] = args[2];
if (args[0] == WIN_SMART) { /* hack -- ide driver does this too... */
@@ -179,7 +181,7 @@ int ata_task_ioctl(struct scsi_device *s
memset(scsi_cmd, 0, sizeof(scsi_cmd));
scsi_cmd[0] = ATA_16;
scsi_cmd[1] = (3 << 1); /* Non-data */
- scsi_cmd[2] = 0x1f; /* no off.line or cc, yes all registers */
+ /* scsi_cmd[2] is already 0 -- no off.line, cc, or data xfer */
scsi_cmd[4] = args[1];
scsi_cmd[6] = args[2];
scsi_cmd[8] = args[3];
--
John W. Linville
linville@tuxdriver.com
next prev parent reply other threads:[~2005-02-18 19:55 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2005-02-18 19:50 [patch libata-dev-2.6 1/5] libata: fix command queue leak when xlat_func fails John W. Linville
2005-02-18 19:55 ` John W. Linville [this message]
2005-02-18 20:03 ` [patch libata-dev-2.6 3/5] libata: filter SET_FEATURES - XFER MODE from ATA pass thru John W. Linville
2005-02-18 20:06 ` [patch libata-dev-2.6 4/5] libata: minor style changes in ata_scsi_pass_thru John W. Linville
2005-02-18 20:16 ` [patch libata-dev-2.6 5/5] libata: update ATA pass thru opcodes John W. Linville
2005-02-18 20:50 ` [patch libata-dev-2.6 1/5] libata: fix command queue leak when xlat_func fails Jeff Garzik
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20050218195512.GC3197@tuxdriver.com \
--to=linville@tuxdriver.com \
--cc=jgarzik@pobox.com \
--cc=linux-ide@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).