From: Tobias Klauser <tklauser@nuerscht.ch>
To: Bartlomiej Zolnierkiewicz <bzolnier@gmail.com>
Cc: kernel-janitors@lists.osdl.org, linux-ide@vger.kernel.org
Subject: [KJ] Re: [PATCH UPDATE] drivers/ide/cs5520.c : Use the DMA_{64, 32}BIT_MASK constants
Date: Thu, 10 Mar 2005 17:59:24 +0100 [thread overview]
Message-ID: <20050310165924.GA4213@localhost.localdomain> (raw)
In-Reply-To: <58cb370e050310083053a0e495@mail.gmail.com>
[-- Attachment #1: Type: text/plain, Size: 2158 bytes --]
On Thu, Mar 10, 2005 at 05:30:12PM +0100, Bartlomiej Zolnierkiewicz wrote:
> On Tue, 8 Mar 2005 14:33:58 +0100, Tobias Klauser <tklauser@nuerscht.ch> wrote:
> > Description: Use the DMA_{64,32}BIT_MASK constants from dma-mapping.h
> > when calling pci_set_dma_mask() or pci_set_consistent_dma_mask()
> > See http://marc.theaimsgroup.com/?t=108001993000001&r=1&w=2 for details
>
> only DMA_32BIT_MASK constant is used in the patch
I just took the same description for all patches of this series. Some of
them do not include DMA_64BIT_MASK.
> > Signed-off-by: Tobias Klauser <tklauser@nuerscht.ch>
> >
> > --- linux-2.6.11.orig/drivers/ide/pci/cs5520.c 2005-03-02 12:50:39.000000000 +0100
> > +++ linux-2.6.11/drivers/ide/pci/cs5520.c 2005-03-03 11:46:46.000000000 +0100
> > @@ -227,7 +227,7 @@ static int __devinit cs5520_init_one(str
> > return 1;
> > }
> > pci_set_master(dev);
> > - if (pci_set_dma_mask(dev, 0xFFFFFFFF)) {
> > + if (pci_set_dma_mask(dev, DMA_32BIT_MASK)) {
> > printk(KERN_WARNING "cs5520: No suitable DMA available.\n");
> > return -ENODEV;
> > }
>
> You need to include <linux/dma-mapping.h> explicitly
> or build will fail for some architectures, i.e. please see:
> http://linus.bkbits.net:8080/linux-2.5/cset@41d833427yYZzu6TxydNrr5z6f02cg?nav=index.html|src/|src/drivers|src/drivers/ide|related/drivers/ide/setup-pci.c
I only compile-tested this patch on x86 and there it worked. So here's an
updated patch:
Signed-off-by: Tobias Klauser <tklauser@nuerscht.ch>
--- linux-2.6.11.orig/drivers/ide/pci/cs5520.c 2005-03-02 12:50:39.000000000 +0100
+++ linux-2.6.11/drivers/ide/pci/cs5520.c 2005-03-10 17:55:23.894909672 +0100
@@ -51,6 +51,8 @@
#include <asm/io.h>
#include <asm/irq.h>
+#include <linux/dma-mapping.h>
+
struct pio_clocks
{
int address;
@@ -227,7 +229,7 @@ static int __devinit cs5520_init_one(str
return 1;
}
pci_set_master(dev);
- if (pci_set_dma_mask(dev, 0xFFFFFFFF)) {
+ if (pci_set_dma_mask(dev, DMA_32BIT_MASK)) {
printk(KERN_WARNING "cs5520: No suitable DMA available.\n");
return -ENODEV;
}
[-- Attachment #2: Type: text/plain, Size: 167 bytes --]
_______________________________________________
Kernel-janitors mailing list
Kernel-janitors@lists.osdl.org
http://lists.osdl.org/mailman/listinfo/kernel-janitors
next prev parent reply other threads:[~2005-03-10 16:59 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2005-03-08 13:33 [PATCH] drivers/ide/cs5520.c : Use the DMA_{64,32}BIT_MASK constants Tobias Klauser
2005-03-10 16:30 ` [KJ] Re: [PATCH] drivers/ide/cs5520.c : Use the DMA_{64, 32}BIT_MASK constants Bartlomiej Zolnierkiewicz
2005-03-10 16:59 ` Tobias Klauser [this message]
2005-03-18 15:23 ` [PATCH UPDATE] drivers/ide/cs5520.c : Use the DMA_{64,32}BIT_MASK constants Bartlomiej Zolnierkiewicz
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20050310165924.GA4213@localhost.localdomain \
--to=tklauser@nuerscht.ch \
--cc=bzolnier@gmail.com \
--cc=kernel-janitors@lists.osdl.org \
--cc=linux-ide@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).