* [2.6 patch] drivers/ide/: possible cleanups
@ 2005-04-30 20:07 Adrian Bunk
2005-05-01 13:37 ` Alan Cox
0 siblings, 1 reply; 12+ messages in thread
From: Adrian Bunk @ 2005-04-30 20:07 UTC (permalink / raw)
To: Andrew Morton; +Cc: B.Zolnierkiewicz, linux-kernel, linux-ide
This patch contains the following possible cleanups:
- pci/cy82c693.c: make a needlessly global function static
- remove the following unneeded EXPORT_SYMBOL's:
- ide-taskfile.c: do_rw_taskfile
- ide-iops.c: default_hwif_iops
- ide-iops.c: default_hwif_transport
- ide-iops.c: wait_for_ready
Signed-off-by: Adrian Bunk <bunk@stusta.de>
---
This patch was already sent on:
- 17 Apr 2005
drivers/ide/ide-iops.c | 6 ------
drivers/ide/ide-taskfile.c | 2 --
drivers/ide/pci/cy82c693.c | 2 +-
3 files changed, 1 insertion(+), 9 deletions(-)
--- linux-2.6.11-rc3-mm1-full/drivers/ide/ide-taskfile.c.old 2005-02-05 02:57:03.000000000 +0100
+++ linux-2.6.11-rc3-mm1-full/drivers/ide/ide-taskfile.c 2005-02-05 02:57:12.000000000 +0100
@@ -161,8 +161,6 @@
return ide_stopped;
}
-EXPORT_SYMBOL(do_rw_taskfile);
-
/*
* set_multmode_intr() is invoked on completion of a WIN_SETMULT cmd.
*/
--- linux-2.6.12-rc2-mm3-full/drivers/ide/pci/cy82c693.c.old 2005-04-17 21:11:22.000000000 +0200
+++ linux-2.6.12-rc2-mm3-full/drivers/ide/pci/cy82c693.c 2005-04-17 21:11:30.000000000 +0200
@@ -469,7 +469,7 @@
static __initdata ide_hwif_t *primary;
-void __init init_iops_cy82c693(ide_hwif_t *hwif)
+static void __init init_iops_cy82c693(ide_hwif_t *hwif)
{
if (PCI_FUNC(hwif->pci_dev->devfn) == 1)
primary = hwif;
--- linux-2.6.12-rc2-mm3-full/drivers/ide/ide-iops.c.old 2005-04-17 21:12:44.000000000 +0200
+++ linux-2.6.12-rc2-mm3-full/drivers/ide/ide-iops.c 2005-04-17 21:12:54.000000000 +0200
@@ -104,8 +104,6 @@
hwif->INSL = ide_insl;
}
-EXPORT_SYMBOL(default_hwif_iops);
-
/*
* MMIO operations, typically used for SATA controllers
*/
@@ -329,8 +327,6 @@
hwif->atapi_output_bytes = atapi_output_bytes;
}
-EXPORT_SYMBOL(default_hwif_transport);
-
/*
* Beginning of Taskfile OPCODE Library and feature sets.
*/
@@ -525,8 +525,6 @@
return 0;
}
-EXPORT_SYMBOL(wait_for_ready);
-
/*
* This routine busy-waits for the drive status to be not "busy".
* It then checks the status for all of the "good" bits and none
^ permalink raw reply [flat|nested] 12+ messages in thread* Re: [2.6 patch] drivers/ide/: possible cleanups
2005-04-30 20:07 [2.6 patch] drivers/ide/: possible cleanups Adrian Bunk
@ 2005-05-01 13:37 ` Alan Cox
2005-05-01 14:29 ` Adrian Bunk
0 siblings, 1 reply; 12+ messages in thread
From: Alan Cox @ 2005-05-01 13:37 UTC (permalink / raw)
To: Adrian Bunk
Cc: Andrew Morton, Bartlomiej Zolnierkiewicz,
Linux Kernel Mailing List, linux-ide
On Sad, 2005-04-30 at 21:07, Adrian Bunk wrote:
> This patch contains the following possible cleanups:
> - pci/cy82c693.c: make a needlessly global function static
> - remove the following unneeded EXPORT_SYMBOL's:
> - ide-taskfile.c: do_rw_taskfile
> - ide-iops.c: default_hwif_iops
> - ide-iops.c: default_hwif_transport
> - ide-iops.c: wait_for_ready
default_*_ops are very much API items not currently used. You need them
if you
want to switch from mmio back to pio (eg doing S3 resume) although
nobody is currently doing that.
wait_for_ready used to be used by ide-probe as a module so seems sane.
^ permalink raw reply [flat|nested] 12+ messages in thread
* Re: [2.6 patch] drivers/ide/: possible cleanups
2005-05-01 13:37 ` Alan Cox
@ 2005-05-01 14:29 ` Adrian Bunk
2005-05-02 1:27 ` Benjamin Herrenschmidt
0 siblings, 1 reply; 12+ messages in thread
From: Adrian Bunk @ 2005-05-01 14:29 UTC (permalink / raw)
To: Alan Cox
Cc: Andrew Morton, Bartlomiej Zolnierkiewicz,
Linux Kernel Mailing List, linux-ide
On Sun, May 01, 2005 at 02:37:43PM +0100, Alan Cox wrote:
> On Sad, 2005-04-30 at 21:07, Adrian Bunk wrote:
> > This patch contains the following possible cleanups:
> > - pci/cy82c693.c: make a needlessly global function static
> > - remove the following unneeded EXPORT_SYMBOL's:
> > - ide-taskfile.c: do_rw_taskfile
> > - ide-iops.c: default_hwif_iops
> > - ide-iops.c: default_hwif_transport
> > - ide-iops.c: wait_for_ready
>
> default_*_ops are very much API items not currently used. You need them
> if you
> want to switch from mmio back to pio (eg doing S3 resume) although
> nobody is currently doing that.
My patch only removes the EXPORT_SYMBOL's.
The functions themselves stay (since they are used), and if someone
wants at some time in the future use them from a module, re-adding them
will be trivial.
> wait_for_ready used to be used by ide-probe as a module so seems sane.
cu
Adrian
--
"Is there not promise of rain?" Ling Tan asked suddenly out
of the darkness. There had been need of rain for many days.
"Only a promise," Lao Er said.
Pearl S. Buck - Dragon Seed
^ permalink raw reply [flat|nested] 12+ messages in thread* Re: [2.6 patch] drivers/ide/: possible cleanups
2005-05-01 14:29 ` Adrian Bunk
@ 2005-05-02 1:27 ` Benjamin Herrenschmidt
0 siblings, 0 replies; 12+ messages in thread
From: Benjamin Herrenschmidt @ 2005-05-02 1:27 UTC (permalink / raw)
To: Adrian Bunk
Cc: Alan Cox, Andrew Morton, Bartlomiej Zolnierkiewicz,
Linux Kernel Mailing List, list linux-ide
On Sun, 2005-05-01 at 16:29 +0200, Adrian Bunk wrote:
> On Sun, May 01, 2005 at 02:37:43PM +0100, Alan Cox wrote:
> > On Sad, 2005-04-30 at 21:07, Adrian Bunk wrote:
> > > This patch contains the following possible cleanups:
> > > - pci/cy82c693.c: make a needlessly global function static
> > > - remove the following unneeded EXPORT_SYMBOL's:
> > > - ide-taskfile.c: do_rw_taskfile
> > > - ide-iops.c: default_hwif_iops
> > > - ide-iops.c: default_hwif_transport
> > > - ide-iops.c: wait_for_ready
> >
> > default_*_ops are very much API items not currently used. You need them
> > if you
> > want to switch from mmio back to pio (eg doing S3 resume) although
> > nobody is currently doing that.
>
> My patch only removes the EXPORT_SYMBOL's.
>
> The functions themselves stay (since they are used), and if someone
> wants at some time in the future use them from a module, re-adding them
> will be trivial.
Hrm... well, that means if I ever want ide-pmac for example to be a
module, I'll have to add them back...
On the other hand, I agree that their names aren't very nice for
exported symbols... they should have been ide_*
Ben.
^ permalink raw reply [flat|nested] 12+ messages in thread
* [2.6 patch] drivers/ide/: possible cleanups
@ 2005-11-03 18:14 Adrian Bunk
2005-11-09 22:07 ` Bartlomiej Zolnierkiewicz
0 siblings, 1 reply; 12+ messages in thread
From: Adrian Bunk @ 2005-11-03 18:14 UTC (permalink / raw)
To: Andrew Morton; +Cc: B.Zolnierkiewicz, linux-kernel, linux-ide
This patch contains the following possible cleanups:
- pci/cy82c693.c: make a needlessly global function static
- remove the following unneeded EXPORT_SYMBOL's:
- ide-taskfile.c: do_rw_taskfile
- ide-iops.c: default_hwif_iops
- ide-iops.c: default_hwif_transport
- ide-iops.c: wait_for_ready
Signed-off-by: Adrian Bunk <bunk@stusta.de>
---
This patch was already sent on:
- 1 Oct 2005
- 20 Aug 2005
drivers/ide/ide-iops.c | 6 ------
drivers/ide/ide-taskfile.c | 2 --
drivers/ide/pci/cy82c693.c | 2 +-
3 files changed, 1 insertion(+), 9 deletions(-)
--- linux-2.6.11-rc3-mm1-full/drivers/ide/ide-taskfile.c.old 2005-02-05 02:57:03.000000000 +0100
+++ linux-2.6.11-rc3-mm1-full/drivers/ide/ide-taskfile.c 2005-02-05 02:57:12.000000000 +0100
@@ -161,8 +161,6 @@
return ide_stopped;
}
-EXPORT_SYMBOL(do_rw_taskfile);
-
/*
* set_multmode_intr() is invoked on completion of a WIN_SETMULT cmd.
*/
--- linux-2.6.12-rc2-mm3-full/drivers/ide/pci/cy82c693.c.old 2005-04-17 21:11:22.000000000 +0200
+++ linux-2.6.12-rc2-mm3-full/drivers/ide/pci/cy82c693.c 2005-04-17 21:11:30.000000000 +0200
@@ -469,7 +469,7 @@
static __initdata ide_hwif_t *primary;
-void __devinit init_iops_cy82c693(ide_hwif_t *hwif)
+static void __devinit init_iops_cy82c693(ide_hwif_t *hwif)
{
if (PCI_FUNC(hwif->pci_dev->devfn) == 1)
primary = hwif;
--- linux-2.6.12-rc2-mm3-full/drivers/ide/ide-iops.c.old 2005-04-17 21:12:44.000000000 +0200
+++ linux-2.6.12-rc2-mm3-full/drivers/ide/ide-iops.c 2005-04-17 21:12:54.000000000 +0200
@@ -104,8 +104,6 @@
hwif->INSL = ide_insl;
}
-EXPORT_SYMBOL(default_hwif_iops);
-
/*
* MMIO operations, typically used for SATA controllers
*/
@@ -329,8 +327,6 @@
hwif->atapi_output_bytes = atapi_output_bytes;
}
-EXPORT_SYMBOL(default_hwif_transport);
-
/*
* Beginning of Taskfile OPCODE Library and feature sets.
*/
@@ -525,8 +525,6 @@
return 0;
}
-EXPORT_SYMBOL(wait_for_ready);
-
/*
* This routine busy-waits for the drive status to be not "busy".
* It then checks the status for all of the "good" bits and none
^ permalink raw reply [flat|nested] 12+ messages in thread* [2.6 patch] drivers/ide/: possible cleanups
@ 2005-10-01 15:53 Adrian Bunk
0 siblings, 0 replies; 12+ messages in thread
From: Adrian Bunk @ 2005-10-01 15:53 UTC (permalink / raw)
To: B.Zolnierkiewicz; +Cc: linux-kernel, linux-ide
This patch contains the following possible cleanups:
- pci/cy82c693.c: make a needlessly global function static
- remove the following unneeded EXPORT_SYMBOL's:
- ide-taskfile.c: do_rw_taskfile
- ide-iops.c: default_hwif_iops
- ide-iops.c: default_hwif_transport
- ide-iops.c: wait_for_ready
Signed-off-by: Adrian Bunk <bunk@stusta.de>
---
This patch was already sent on:
- 20 Aug 2005
drivers/ide/ide-iops.c | 6 ------
drivers/ide/ide-taskfile.c | 2 --
drivers/ide/pci/cy82c693.c | 2 +-
3 files changed, 1 insertion(+), 9 deletions(-)
--- linux-2.6.11-rc3-mm1-full/drivers/ide/ide-taskfile.c.old 2005-02-05 02:57:03.000000000 +0100
+++ linux-2.6.11-rc3-mm1-full/drivers/ide/ide-taskfile.c 2005-02-05 02:57:12.000000000 +0100
@@ -161,8 +161,6 @@
return ide_stopped;
}
-EXPORT_SYMBOL(do_rw_taskfile);
-
/*
* set_multmode_intr() is invoked on completion of a WIN_SETMULT cmd.
*/
--- linux-2.6.12-rc2-mm3-full/drivers/ide/pci/cy82c693.c.old 2005-04-17 21:11:22.000000000 +0200
+++ linux-2.6.12-rc2-mm3-full/drivers/ide/pci/cy82c693.c 2005-04-17 21:11:30.000000000 +0200
@@ -469,7 +469,7 @@
static __initdata ide_hwif_t *primary;
-void __devinit init_iops_cy82c693(ide_hwif_t *hwif)
+static void __devinit init_iops_cy82c693(ide_hwif_t *hwif)
{
if (PCI_FUNC(hwif->pci_dev->devfn) == 1)
primary = hwif;
--- linux-2.6.12-rc2-mm3-full/drivers/ide/ide-iops.c.old 2005-04-17 21:12:44.000000000 +0200
+++ linux-2.6.12-rc2-mm3-full/drivers/ide/ide-iops.c 2005-04-17 21:12:54.000000000 +0200
@@ -104,8 +104,6 @@
hwif->INSL = ide_insl;
}
-EXPORT_SYMBOL(default_hwif_iops);
-
/*
* MMIO operations, typically used for SATA controllers
*/
@@ -329,8 +327,6 @@
hwif->atapi_output_bytes = atapi_output_bytes;
}
-EXPORT_SYMBOL(default_hwif_transport);
-
/*
* Beginning of Taskfile OPCODE Library and feature sets.
*/
@@ -525,8 +525,6 @@
return 0;
}
-EXPORT_SYMBOL(wait_for_ready);
-
/*
* This routine busy-waits for the drive status to be not "busy".
* It then checks the status for all of the "good" bits and none
^ permalink raw reply [flat|nested] 12+ messages in thread* [2.6 patch] drivers/ide/: possible cleanups
@ 2005-08-20 19:02 Adrian Bunk
0 siblings, 0 replies; 12+ messages in thread
From: Adrian Bunk @ 2005-08-20 19:02 UTC (permalink / raw)
To: B.Zolnierkiewicz; +Cc: linux-kernel, linux-ide
This patch contains the following possible cleanups:
- pci/cy82c693.c: make a needlessly global function static
- remove the following unneeded EXPORT_SYMBOL's:
- ide-taskfile.c: do_rw_taskfile
- ide-iops.c: default_hwif_iops
- ide-iops.c: default_hwif_transport
- ide-iops.c: wait_for_ready
Signed-off-by: Adrian Bunk <bunk@stusta.de>
---
drivers/ide/ide-iops.c | 6 ------
drivers/ide/ide-taskfile.c | 2 --
drivers/ide/pci/cy82c693.c | 2 +-
3 files changed, 1 insertion(+), 9 deletions(-)
--- linux-2.6.11-rc3-mm1-full/drivers/ide/ide-taskfile.c.old 2005-02-05 02:57:03.000000000 +0100
+++ linux-2.6.11-rc3-mm1-full/drivers/ide/ide-taskfile.c 2005-02-05 02:57:12.000000000 +0100
@@ -161,8 +161,6 @@
return ide_stopped;
}
-EXPORT_SYMBOL(do_rw_taskfile);
-
/*
* set_multmode_intr() is invoked on completion of a WIN_SETMULT cmd.
*/
--- linux-2.6.12-rc2-mm3-full/drivers/ide/pci/cy82c693.c.old 2005-04-17 21:11:22.000000000 +0200
+++ linux-2.6.12-rc2-mm3-full/drivers/ide/pci/cy82c693.c 2005-04-17 21:11:30.000000000 +0200
@@ -469,7 +469,7 @@
static __initdata ide_hwif_t *primary;
-void __devinit init_iops_cy82c693(ide_hwif_t *hwif)
+static void __devinit init_iops_cy82c693(ide_hwif_t *hwif)
{
if (PCI_FUNC(hwif->pci_dev->devfn) == 1)
primary = hwif;
--- linux-2.6.12-rc2-mm3-full/drivers/ide/ide-iops.c.old 2005-04-17 21:12:44.000000000 +0200
+++ linux-2.6.12-rc2-mm3-full/drivers/ide/ide-iops.c 2005-04-17 21:12:54.000000000 +0200
@@ -104,8 +104,6 @@
hwif->INSL = ide_insl;
}
-EXPORT_SYMBOL(default_hwif_iops);
-
/*
* MMIO operations, typically used for SATA controllers
*/
@@ -329,8 +327,6 @@
hwif->atapi_output_bytes = atapi_output_bytes;
}
-EXPORT_SYMBOL(default_hwif_transport);
-
/*
* Beginning of Taskfile OPCODE Library and feature sets.
*/
@@ -525,8 +525,6 @@
return 0;
}
-EXPORT_SYMBOL(wait_for_ready);
-
/*
* This routine busy-waits for the drive status to be not "busy".
* It then checks the status for all of the "good" bits and none
^ permalink raw reply [flat|nested] 12+ messages in thread* [2.6 patch] drivers/ide/: possible cleanups
@ 2005-05-30 20:56 Adrian Bunk
2005-05-30 21:44 ` Benjamin Herrenschmidt
0 siblings, 1 reply; 12+ messages in thread
From: Adrian Bunk @ 2005-05-30 20:56 UTC (permalink / raw)
To: Andrew Morton; +Cc: B.Zolnierkiewicz, linux-kernel, linux-ide
This patch contains the following possible cleanups:
- pci/cy82c693.c: make a needlessly global function static
- remove the following unneeded EXPORT_SYMBOL's:
- ide-taskfile.c: do_rw_taskfile
- ide-iops.c: default_hwif_iops
- ide-iops.c: default_hwif_transport
- ide-iops.c: wait_for_ready
Signed-off-by: Adrian Bunk <bunk@stusta.de>
---
This patch was already sent on:
- 30 Apr 200
- 17 Apr 2005
drivers/ide/ide-iops.c | 6 ------
drivers/ide/ide-taskfile.c | 2 --
drivers/ide/pci/cy82c693.c | 2 +-
3 files changed, 1 insertion(+), 9 deletions(-)
--- linux-2.6.11-rc3-mm1-full/drivers/ide/ide-taskfile.c.old 2005-02-05 02:57:03.000000000 +0100
+++ linux-2.6.11-rc3-mm1-full/drivers/ide/ide-taskfile.c 2005-02-05 02:57:12.000000000 +0100
@@ -161,8 +161,6 @@
return ide_stopped;
}
-EXPORT_SYMBOL(do_rw_taskfile);
-
/*
* set_multmode_intr() is invoked on completion of a WIN_SETMULT cmd.
*/
--- linux-2.6.12-rc2-mm3-full/drivers/ide/pci/cy82c693.c.old 2005-04-17 21:11:22.000000000 +0200
+++ linux-2.6.12-rc2-mm3-full/drivers/ide/pci/cy82c693.c 2005-04-17 21:11:30.000000000 +0200
@@ -469,7 +469,7 @@
static __initdata ide_hwif_t *primary;
-void __init init_iops_cy82c693(ide_hwif_t *hwif)
+static void __init init_iops_cy82c693(ide_hwif_t *hwif)
{
if (PCI_FUNC(hwif->pci_dev->devfn) == 1)
primary = hwif;
--- linux-2.6.12-rc2-mm3-full/drivers/ide/ide-iops.c.old 2005-04-17 21:12:44.000000000 +0200
+++ linux-2.6.12-rc2-mm3-full/drivers/ide/ide-iops.c 2005-04-17 21:12:54.000000000 +0200
@@ -104,8 +104,6 @@
hwif->INSL = ide_insl;
}
-EXPORT_SYMBOL(default_hwif_iops);
-
/*
* MMIO operations, typically used for SATA controllers
*/
@@ -329,8 +327,6 @@
hwif->atapi_output_bytes = atapi_output_bytes;
}
-EXPORT_SYMBOL(default_hwif_transport);
-
/*
* Beginning of Taskfile OPCODE Library and feature sets.
*/
@@ -525,8 +525,6 @@
return 0;
}
-EXPORT_SYMBOL(wait_for_ready);
-
/*
* This routine busy-waits for the drive status to be not "busy".
* It then checks the status for all of the "good" bits and none
^ permalink raw reply [flat|nested] 12+ messages in thread* Re: [2.6 patch] drivers/ide/: possible cleanups
2005-05-30 20:56 Adrian Bunk
@ 2005-05-30 21:44 ` Benjamin Herrenschmidt
2005-05-30 21:57 ` Adrian Bunk
0 siblings, 1 reply; 12+ messages in thread
From: Benjamin Herrenschmidt @ 2005-05-30 21:44 UTC (permalink / raw)
To: Adrian Bunk; +Cc: Andrew Morton, B.Zolnierkiewicz, linux-kernel, linux-ide
On Mon, 2005-05-30 at 22:56 +0200, Adrian Bunk wrote:
> This patch contains the following possible cleanups:
> - pci/cy82c693.c: make a needlessly global function static
> - remove the following unneeded EXPORT_SYMBOL's:
> - ide-taskfile.c: do_rw_taskfile
> - ide-iops.c: default_hwif_iops
> - ide-iops.c: default_hwif_transport
> - ide-iops.c: wait_for_ready
Are we sure we want to do that ? That would mean never having IDE host
controller drivers as modules...
I was thinking about toying with that again for pmac one of these
days ...
It may be worth, however, to rename those exported symbols to ide_*
Ben.
^ permalink raw reply [flat|nested] 12+ messages in thread
* Re: [2.6 patch] drivers/ide/: possible cleanups
2005-05-30 21:44 ` Benjamin Herrenschmidt
@ 2005-05-30 21:57 ` Adrian Bunk
0 siblings, 0 replies; 12+ messages in thread
From: Adrian Bunk @ 2005-05-30 21:57 UTC (permalink / raw)
To: Benjamin Herrenschmidt
Cc: Andrew Morton, B.Zolnierkiewicz, linux-kernel, linux-ide
On Tue, May 31, 2005 at 07:44:36AM +1000, Benjamin Herrenschmidt wrote:
> On Mon, 2005-05-30 at 22:56 +0200, Adrian Bunk wrote:
> > This patch contains the following possible cleanups:
> > - pci/cy82c693.c: make a needlessly global function static
> > - remove the following unneeded EXPORT_SYMBOL's:
> > - ide-taskfile.c: do_rw_taskfile
> > - ide-iops.c: default_hwif_iops
> > - ide-iops.c: default_hwif_transport
> > - ide-iops.c: wait_for_ready
>
> Are we sure we want to do that ? That would mean never having IDE host
> controller drivers as modules...
>
> I was thinking about toying with that again for pmac one of these
> days ...
>
> It may be worth, however, to rename those exported symbols to ide_*
My patch only removes the EXPORT_SYMBOL's.
It's always trivial to re-add them when you need them.
> Ben.
cu
Adrian
--
"Is there not promise of rain?" Ling Tan asked suddenly out
of the darkness. There had been need of rain for many days.
"Only a promise," Lao Er said.
Pearl S. Buck - Dragon Seed
^ permalink raw reply [flat|nested] 12+ messages in thread
* [2.6 patch] drivers/ide/: possible cleanups
@ 2005-04-17 20:02 Adrian Bunk
0 siblings, 0 replies; 12+ messages in thread
From: Adrian Bunk @ 2005-04-17 20:02 UTC (permalink / raw)
To: B.Zolnierkiewicz; +Cc: linux-kernel, linux-ide
This patch contains the following possible cleanups:
- pci/cy82c693.c: make a needlessly global function statix
- remove the following unneeded EXPORT_SYMBOL's:
- ide-taskfile.c: do_rw_taskfile
- ide-iops.c: default_hwif_iops
- ide-iops.c: default_hwif_transport
- ide-iops.c: wait_for_ready
Signed-off-by: Adrian Bunk <bunk@stusta.de>
---
drivers/ide/ide-iops.c | 6 ------
drivers/ide/ide-taskfile.c | 2 --
drivers/ide/pci/cy82c693.c | 2 +-
3 files changed, 1 insertion(+), 9 deletions(-)
--- linux-2.6.11-rc3-mm1-full/drivers/ide/ide-taskfile.c.old 2005-02-05 02:57:03.000000000 +0100
+++ linux-2.6.11-rc3-mm1-full/drivers/ide/ide-taskfile.c 2005-02-05 02:57:12.000000000 +0100
@@ -161,8 +161,6 @@
return ide_stopped;
}
-EXPORT_SYMBOL(do_rw_taskfile);
-
/*
* set_multmode_intr() is invoked on completion of a WIN_SETMULT cmd.
*/
--- linux-2.6.12-rc2-mm3-full/drivers/ide/pci/cy82c693.c.old 2005-04-17 21:11:22.000000000 +0200
+++ linux-2.6.12-rc2-mm3-full/drivers/ide/pci/cy82c693.c 2005-04-17 21:11:30.000000000 +0200
@@ -469,7 +469,7 @@
static __initdata ide_hwif_t *primary;
-void __init init_iops_cy82c693(ide_hwif_t *hwif)
+static void __init init_iops_cy82c693(ide_hwif_t *hwif)
{
if (PCI_FUNC(hwif->pci_dev->devfn) == 1)
primary = hwif;
--- linux-2.6.12-rc2-mm3-full/drivers/ide/ide-iops.c.old 2005-04-17 21:12:44.000000000 +0200
+++ linux-2.6.12-rc2-mm3-full/drivers/ide/ide-iops.c 2005-04-17 21:12:54.000000000 +0200
@@ -104,8 +104,6 @@
hwif->INSL = ide_insl;
}
-EXPORT_SYMBOL(default_hwif_iops);
-
/*
* MMIO operations, typically used for SATA controllers
*/
@@ -329,8 +327,6 @@
hwif->atapi_output_bytes = atapi_output_bytes;
}
-EXPORT_SYMBOL(default_hwif_transport);
-
/*
* Beginning of Taskfile OPCODE Library and feature sets.
*/
@@ -525,8 +525,6 @@
return 0;
}
-EXPORT_SYMBOL(wait_for_ready);
-
/*
* This routine busy-waits for the drive status to be not "busy".
* It then checks the status for all of the "good" bits and none
^ permalink raw reply [flat|nested] 12+ messages in thread
end of thread, other threads:[~2005-11-09 22:07 UTC | newest]
Thread overview: 12+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2005-04-30 20:07 [2.6 patch] drivers/ide/: possible cleanups Adrian Bunk
2005-05-01 13:37 ` Alan Cox
2005-05-01 14:29 ` Adrian Bunk
2005-05-02 1:27 ` Benjamin Herrenschmidt
-- strict thread matches above, loose matches on Subject: below --
2005-11-03 18:14 Adrian Bunk
2005-11-09 22:07 ` Bartlomiej Zolnierkiewicz
2005-10-01 15:53 Adrian Bunk
2005-08-20 19:02 Adrian Bunk
2005-05-30 20:56 Adrian Bunk
2005-05-30 21:44 ` Benjamin Herrenschmidt
2005-05-30 21:57 ` Adrian Bunk
2005-04-17 20:02 Adrian Bunk
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).