From: Jens Axboe <axboe@suse.de>
To: Jeff Garzik <jgarzik@pobox.com>
Cc: linux-ide@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] SATA NCQ support
Date: Fri, 27 May 2005 10:35:11 +0200 [thread overview]
Message-ID: <20050527083509.GT1435@suse.de> (raw)
In-Reply-To: <4296DA4B.6040303@pobox.com>
On Fri, May 27 2005, Jeff Garzik wrote:
> Jens Axboe wrote:
> >On Fri, May 27 2005, Jeff Garzik wrote:
> >>I just noticed a bug -- When ata_scsi_qc_new() fails, the code should
> >>complete the command with queue-full, but does not.
> >>
> >> qc = ata_scsi_qc_new(ap, dev, cmd, done);
> >> if (!qc)
> >> return;
> >
> >
> >Indeed, looks like an old bug.
>
> Yep. If you are knocking around in that area, would you mind killing it
> for me? :)
Actually, I didn't look far enough up - ata_scsi_qc_new() already
completes the command with QUEUE_FULL if ata_qc_new_init() fails. So
there's no bug, but perhaps it would be cleaner to move it to
ata_scsi_translate instead?
--
Jens Axboe
next prev parent reply other threads:[~2005-05-27 8:34 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2005-05-27 7:03 [PATCH] SATA NCQ support Jens Axboe
2005-05-27 7:22 ` Jeff Garzik
2005-05-27 7:30 ` Jens Axboe
2005-05-27 7:37 ` Jeff Garzik
2005-05-27 7:47 ` Jens Axboe
2005-05-27 7:56 ` Jens Axboe
2005-05-27 8:24 ` Jeff Garzik
2005-05-27 8:27 ` Jeff Garzik
2005-05-27 8:28 ` Jeff Garzik
2005-05-27 8:35 ` Jens Axboe [this message]
2005-05-27 8:38 ` Jeff Garzik
2005-05-27 8:42 ` Jens Axboe
2005-05-27 23:47 ` Jeff Garzik
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20050527083509.GT1435@suse.de \
--to=axboe@suse.de \
--cc=jgarzik@pobox.com \
--cc=linux-ide@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).