From mboxrd@z Thu Jan 1 00:00:00 1970 From: Adrian Bunk Subject: Re: [2.6 patch] drivers/ide/: possible cleanups Date: Mon, 30 May 2005 23:57:33 +0200 Message-ID: <20050530215733.GB3627@stusta.de> References: <20050530205631.GP10441@stusta.de> <1117489476.5194.6.camel@gaston> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Return-path: Received: from emailhub.stusta.mhn.de ([141.84.69.5]:33039 "HELO mailout.stusta.mhn.de") by vger.kernel.org with SMTP id S261778AbVE3V5f (ORCPT ); Mon, 30 May 2005 17:57:35 -0400 Content-Disposition: inline In-Reply-To: <1117489476.5194.6.camel@gaston> Sender: linux-ide-owner@vger.kernel.org List-Id: linux-ide@vger.kernel.org To: Benjamin Herrenschmidt Cc: Andrew Morton , B.Zolnierkiewicz@elka.pw.edu.pl, linux-kernel@vger.kernel.org, linux-ide@vger.kernel.org On Tue, May 31, 2005 at 07:44:36AM +1000, Benjamin Herrenschmidt wrote: > On Mon, 2005-05-30 at 22:56 +0200, Adrian Bunk wrote: > > This patch contains the following possible cleanups: > > - pci/cy82c693.c: make a needlessly global function static > > - remove the following unneeded EXPORT_SYMBOL's: > > - ide-taskfile.c: do_rw_taskfile > > - ide-iops.c: default_hwif_iops > > - ide-iops.c: default_hwif_transport > > - ide-iops.c: wait_for_ready > > Are we sure we want to do that ? That would mean never having IDE host > controller drivers as modules... > > I was thinking about toying with that again for pmac one of these > days ... > > It may be worth, however, to rename those exported symbols to ide_* My patch only removes the EXPORT_SYMBOL's. It's always trivial to re-add them when you need them. > Ben. cu Adrian -- "Is there not promise of rain?" Ling Tan asked suddenly out of the darkness. There had been need of rain for many days. "Only a promise," Lao Er said. Pearl S. Buck - Dragon Seed