From: Jens Axboe <axboe@suse.de>
To: Sergio Navarro i Fajardo <navarro_ser@gva.es>
Cc: Jeff Garzik <jgarzik@pobox.com>, linux-ide@vger.kernel.org
Subject: Re: sata_sil: Fix FIFO PCI Bus Arbitration KERNEL OOPS!
Date: Wed, 8 Jun 2005 13:02:25 +0200 [thread overview]
Message-ID: <20050608110225.GD18490@suse.de> (raw)
In-Reply-To: <200506081234.14415.navarro_ser@gva.es>
On Wed, Jun 08 2005, Sergio Navarro i Fajardo wrote:
> Hi!
> Kernel 2.6.12-rc5 includes patch references on mail:
> --
> Re: [RFT, PATCH] sata_sil corruption / lockup fix
> http://marc.theaimsgroup.com/?l=linux-ide&m=111818249232162&w=2
> [PATCH] sata_sil: Fix FIFO PCI Bus Arbitration
> --
> But, this patch produces an oops on load modules sata_sil on my system:
> sata_sil version 0.9
Please try with attached patch.
diff --git a/drivers/scsi/sata_sil.c b/drivers/scsi/sata_sil.c
--- a/drivers/scsi/sata_sil.c
+++ b/drivers/scsi/sata_sil.c
@@ -432,7 +432,13 @@ static int sil_init_one (struct pci_dev
writeb(cls, mmio_base + SIL_FIFO_R0);
writeb(cls, mmio_base + SIL_FIFO_W0);
writeb(cls, mmio_base + SIL_FIFO_R1);
- writeb(cls, mmio_base + SIL_FIFO_W2);
+ writeb(cls, mmio_base + SIL_FIFO_W1);
+ if (ent->driver_data == sil_3114) {
+ writeb(cls, mmio_base + SIL_FIFO_R2);
+ writeb(cls, mmio_base + SIL_FIFO_W2);
+ writeb(cls, mmio_base + SIL_FIFO_R3);
+ writeb(cls, mmio_base + SIL_FIFO_W3);
+ }
} else
printk(KERN_WARNING DRV_NAME "(%s): cache line size not set. Driver may not function\n",
pci_name(pdev));
--
Jens Axboe
prev parent reply other threads:[~2005-06-08 11:01 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2005-06-08 10:34 sata_sil: Fix FIFO PCI Bus Arbitration KERNEL OOPS! Sergio Navarro i Fajardo
2005-06-08 11:02 ` Jens Axboe [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20050608110225.GD18490@suse.de \
--to=axboe@suse.de \
--cc=jgarzik@pobox.com \
--cc=linux-ide@vger.kernel.org \
--cc=navarro_ser@gva.es \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).