From: domen@coderock.org
To: B.Zolnierkiewicz@elka.pw.edu.pl
Cc: linux-ide@vger.kernel.org, Amit Gud <gud@eth.net>, domen@coderock.org
Subject: [patch 3/6] Resend: drivers/ide/pci/cs5520.c fix return code value
Date: Mon, 20 Jun 2005 23:52:19 +0200 [thread overview]
Message-ID: <20050620215218.450082000@nd47.coderock.org> (raw)
[-- Attachment #1: return_code-drivers_ide_pci_cs5520.patch --]
[-- Type: text/plain, Size: 798 bytes --]
From: Amit Gud <amitg@calsoftinc.com>
The patch follows from the suggestions by AC and Felipe W Damasio for fixing the return codes from IDE drivers.
Do consider applying.
Signed-off-by: Amit Gud <gud@eth.net>
Signed-off-by: Domen Puncer <domen@coderock.org>
---
cs5520.c | 2 +-
1 files changed, 1 insertion(+), 1 deletion(-)
Index: quilt/drivers/ide/pci/cs5520.c
===================================================================
--- quilt.orig/drivers/ide/pci/cs5520.c
+++ quilt/drivers/ide/pci/cs5520.c
@@ -225,7 +225,7 @@ static int __devinit cs5520_init_one(str
if(pci_enable_device_bars(dev, 1<<2))
{
printk(KERN_WARNING "%s: Unable to enable 55x0.\n", d->name);
- return 1;
+ return -ENODEV;
}
pci_set_master(dev);
if (pci_set_dma_mask(dev, DMA_32BIT_MASK)) {
--
next reply other threads:[~2005-06-20 21:56 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2005-06-20 21:52 domen [this message]
-- strict thread matches above, loose matches on Subject: below --
2005-03-06 10:42 [patch 3/6] Resend: drivers/ide/pci/cs5520.c fix return code value domen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20050620215218.450082000@nd47.coderock.org \
--to=domen@coderock.org \
--cc=B.Zolnierkiewicz@elka.pw.edu.pl \
--cc=gud@eth.net \
--cc=linux-ide@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).