* [patch 3/6] Resend: drivers/ide/pci/cs5520.c fix return code value
@ 2005-06-20 21:52 domen
0 siblings, 0 replies; 2+ messages in thread
From: domen @ 2005-06-20 21:52 UTC (permalink / raw)
To: B.Zolnierkiewicz; +Cc: linux-ide, Amit Gud, domen
[-- Attachment #1: return_code-drivers_ide_pci_cs5520.patch --]
[-- Type: text/plain, Size: 798 bytes --]
From: Amit Gud <amitg@calsoftinc.com>
The patch follows from the suggestions by AC and Felipe W Damasio for fixing the return codes from IDE drivers.
Do consider applying.
Signed-off-by: Amit Gud <gud@eth.net>
Signed-off-by: Domen Puncer <domen@coderock.org>
---
cs5520.c | 2 +-
1 files changed, 1 insertion(+), 1 deletion(-)
Index: quilt/drivers/ide/pci/cs5520.c
===================================================================
--- quilt.orig/drivers/ide/pci/cs5520.c
+++ quilt/drivers/ide/pci/cs5520.c
@@ -225,7 +225,7 @@ static int __devinit cs5520_init_one(str
if(pci_enable_device_bars(dev, 1<<2))
{
printk(KERN_WARNING "%s: Unable to enable 55x0.\n", d->name);
- return 1;
+ return -ENODEV;
}
pci_set_master(dev);
if (pci_set_dma_mask(dev, DMA_32BIT_MASK)) {
--
^ permalink raw reply [flat|nested] 2+ messages in thread* [patch 3/6] Resend: drivers/ide/pci/cs5520.c fix return code value
@ 2005-03-06 10:42 domen
0 siblings, 0 replies; 2+ messages in thread
From: domen @ 2005-03-06 10:42 UTC (permalink / raw)
To: B.Zolnierkiewicz; +Cc: linux-ide, domen, amitg, gud
The patch follows from the suggestions by AC and Felipe W Damasio for fixing the return codes from IDE drivers.
Do consider applying.
Signed-off-by: Amit Gud <gud@eth.net>
Signed-off-by: Domen Puncer <domen@coderock.org>
---
kj-domen/drivers/ide/pci/cs5520.c | 2 +-
1 files changed, 1 insertion(+), 1 deletion(-)
diff -puN drivers/ide/pci/cs5520.c~return_code-drivers_ide_pci_cs5520 drivers/ide/pci/cs5520.c
--- kj/drivers/ide/pci/cs5520.c~return_code-drivers_ide_pci_cs5520 2005-03-05 16:11:10.000000000 +0100
+++ kj-domen/drivers/ide/pci/cs5520.c 2005-03-05 16:11:10.000000000 +0100
@@ -224,7 +224,7 @@ static int __devinit cs5520_init_one(str
if(pci_enable_device_bars(dev, 1<<2))
{
printk(KERN_WARNING "%s: Unable to enable 55x0.\n", d->name);
- return 1;
+ return -ENODEV;
}
pci_set_master(dev);
if (pci_set_dma_mask(dev, 0xFFFFFFFF)) {
_
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2005-06-20 21:56 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2005-06-20 21:52 [patch 3/6] Resend: drivers/ide/pci/cs5520.c fix return code value domen
-- strict thread matches above, loose matches on Subject: below --
2005-03-06 10:42 domen
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).