From: Jens Axboe <axboe@suse.de>
To: Jeff Garzik <jgarzik@pobox.com>
Cc: Tejun Heo <htejun@gmail.com>, linux-ide@vger.kernel.org
Subject: Re: [PATCH] libata-dev-2.6-ncq: rewrite __ata_qc_complete
Date: Mon, 27 Jun 2005 10:27:10 +0200 [thread overview]
Message-ID: <20050627082709.GO19550@suse.de> (raw)
In-Reply-To: <42BEE593.7050004@pobox.com>
On Sun, Jun 26 2005, Jeff Garzik wrote:
> Tejun Heo wrote:
> > Hello, Jeff.
> > Hello, Jens.
> >
> > This is the fource, no, fourth (dang, that starwars) of six misc
> >updates to ncq.
> >
> > This patch rewrites __ata_qc_complete() to make it look more sane.
> >Also, remove spurious clearing of ATA_QCFLAG_ACTIVE from
> >ata_qc_complete().
> >
> > Signed-off-by: Tejun Heo <htejun@gmail.com>
>
> I'll have to stare at this a bit more. This has big potential for
> creating races if not perfect.
It looks good to me.
--
Jens Axboe
next prev parent reply other threads:[~2005-06-27 8:25 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2005-06-26 14:41 [PATCH] libata-dev-2.6-ncq: rewrite __ata_qc_complete Tejun Heo
2005-06-26 17:27 ` Jeff Garzik
2005-06-27 8:27 ` Jens Axboe [this message]
2005-06-27 9:27 ` Albert Lee
2005-06-27 11:13 ` Tejun Heo
2005-06-27 12:30 ` Jeff Garzik
2005-06-27 13:21 ` Tejun Heo
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20050627082709.GO19550@suse.de \
--to=axboe@suse.de \
--cc=htejun@gmail.com \
--cc=jgarzik@pobox.com \
--cc=linux-ide@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).