From: Jens Axboe <axboe@suse.de>
To: Jeff Garzik <jgarzik@pobox.com>
Cc: maximilian attems <debian@sternwelten.at>,
B.Zolnierkiewicz@elka.pw.edu.pl, linux-ide@vger.kernel.org,
Herbert Xu <herbert@gondor.apana.org.au>
Subject: Re: [patch] ide dma blacklist toshiba
Date: Tue, 28 Jun 2005 08:27:26 +0200 [thread overview]
Message-ID: <20050628062725.GD3411@suse.de> (raw)
In-Reply-To: <42C0CB99.9000105@pobox.com>
On Tue, Jun 28 2005, Jeff Garzik wrote:
> Jens Axboe wrote:
> >On Sun, Jun 26 2005, Jeff Garzik wrote:
> >
> >>maximilian attems wrote:
> >>
> >>>--- kernel-source-2.6.6/drivers/ide/ide-dma.c 2004-04-05
> >>>19:49:28.000000000 +1000
> >>>+++ kernel-source-2.6.6-1/drivers/ide/ide-dma.c 2004-04-05
> >>>20:54:34.000000000 +1000
> >>>@@ -125,6 +125,7 @@
> >>> { "HITACHI CDR-8335" , "ALL" },
> >>> { "HITACHI CDR-8435" , "ALL" },
> >>> { "Toshiba CD-ROM XM-6202B" , "ALL" },
> >>>+ { "TOSHIBA CD-ROM XM-1702BC" , "ALL" },
> >>> { "CD-532E-A" , "ALL" },
> >>> { "E-IDE CD-ROM CR-840", "ALL" },
> >>> { "CD-ROM Drive/F5A", "ALL" },
> >>
> >>
> >>When touching the blacklist, always make sure to patch
> >>ata_dma_blacklist[] (drivers/scsi/libata-core.c) in the same patch (or
> >>aonther patch mailed at the same time).
> >
> >
> >This has come up at least two times in the last week already, how about
> >adding a unified dma blacklist to ata.h instead?
>
> Feel free to submit a patch :)
Hehe, somehow I knew that was going to be the response :-)
--
Jens Axboe
next prev parent reply other threads:[~2005-06-28 6:26 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2005-06-26 16:55 [patch] ide dma blacklist toshiba maximilian attems
2005-06-26 17:44 ` Jeff Garzik
2005-06-26 17:48 ` maximilian attems
2005-06-26 18:01 ` [patch] libata dma blacklist toshiba cdrom drive maximilian attems
2005-06-27 7:24 ` [patch] ide dma blacklist toshiba Jens Axboe
2005-06-28 4:01 ` Jeff Garzik
2005-06-28 6:27 ` Jens Axboe [this message]
2005-06-28 7:41 ` maximilian attems
2005-06-28 7:49 ` Jens Axboe
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20050628062725.GD3411@suse.de \
--to=axboe@suse.de \
--cc=B.Zolnierkiewicz@elka.pw.edu.pl \
--cc=debian@sternwelten.at \
--cc=herbert@gondor.apana.org.au \
--cc=jgarzik@pobox.com \
--cc=linux-ide@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).