* [patch] ide dma blacklist toshiba
@ 2005-06-26 16:55 maximilian attems
2005-06-26 17:44 ` Jeff Garzik
0 siblings, 1 reply; 9+ messages in thread
From: maximilian attems @ 2005-06-26 16:55 UTC (permalink / raw)
To: B.Zolnierkiewicz; +Cc: linux-ide
From: Herbert Xu <herbert@gondor.apana.org.au>
blacklist "TOSHIBA CD-ROM XM-1702BC"
bug reporter couldn't acces it's cdrom drive otherwise
debian bug -> http://bugs.debian.org/cgi-bin/bugreport.cgi?bug=222939
there are also older reports that this drive doesn't work out of the box:
http://lists.debian.org/debian-boot/1999/02/msg00016.html
Signed-off-by: maximilian attems <janitor@sternwelten.at>
--- kernel-source-2.6.6/drivers/ide/ide-dma.c 2004-04-05 19:49:28.000000000 +1000
+++ kernel-source-2.6.6-1/drivers/ide/ide-dma.c 2004-04-05 20:54:34.000000000 +1000
@@ -125,6 +125,7 @@
{ "HITACHI CDR-8335" , "ALL" },
{ "HITACHI CDR-8435" , "ALL" },
{ "Toshiba CD-ROM XM-6202B" , "ALL" },
+ { "TOSHIBA CD-ROM XM-1702BC" , "ALL" },
{ "CD-532E-A" , "ALL" },
{ "E-IDE CD-ROM CR-840", "ALL" },
{ "CD-ROM Drive/F5A", "ALL" },
^ permalink raw reply [flat|nested] 9+ messages in thread* Re: [patch] ide dma blacklist toshiba 2005-06-26 16:55 [patch] ide dma blacklist toshiba maximilian attems @ 2005-06-26 17:44 ` Jeff Garzik 2005-06-26 17:48 ` maximilian attems ` (2 more replies) 0 siblings, 3 replies; 9+ messages in thread From: Jeff Garzik @ 2005-06-26 17:44 UTC (permalink / raw) To: maximilian attems; +Cc: B.Zolnierkiewicz, linux-ide, Herbert Xu maximilian attems wrote: > --- kernel-source-2.6.6/drivers/ide/ide-dma.c 2004-04-05 19:49:28.000000000 +1000 > +++ kernel-source-2.6.6-1/drivers/ide/ide-dma.c 2004-04-05 20:54:34.000000000 +1000 > @@ -125,6 +125,7 @@ > { "HITACHI CDR-8335" , "ALL" }, > { "HITACHI CDR-8435" , "ALL" }, > { "Toshiba CD-ROM XM-6202B" , "ALL" }, > + { "TOSHIBA CD-ROM XM-1702BC" , "ALL" }, > { "CD-532E-A" , "ALL" }, > { "E-IDE CD-ROM CR-840", "ALL" }, > { "CD-ROM Drive/F5A", "ALL" }, When touching the blacklist, always make sure to patch ata_dma_blacklist[] (drivers/scsi/libata-core.c) in the same patch (or aonther patch mailed at the same time). Jeff ^ permalink raw reply [flat|nested] 9+ messages in thread
* Re: [patch] ide dma blacklist toshiba 2005-06-26 17:44 ` Jeff Garzik @ 2005-06-26 17:48 ` maximilian attems 2005-06-26 18:01 ` [patch] libata dma blacklist toshiba cdrom drive maximilian attems 2005-06-27 7:24 ` [patch] ide dma blacklist toshiba Jens Axboe 2 siblings, 0 replies; 9+ messages in thread From: maximilian attems @ 2005-06-26 17:48 UTC (permalink / raw) To: Jeff Garzik; +Cc: B.Zolnierkiewicz, linux-ide, Herbert Xu On Sun, 26 Jun 2005, Jeff Garzik wrote: > maximilian attems wrote: > >--- kernel-source-2.6.6/drivers/ide/ide-dma.c 2004-04-05 > >19:49:28.000000000 +1000 > >+++ kernel-source-2.6.6-1/drivers/ide/ide-dma.c 2004-04-05 > >20:54:34.000000000 +1000 > >@@ -125,6 +125,7 @@ > > { "HITACHI CDR-8335" , "ALL" }, > > { "HITACHI CDR-8435" , "ALL" }, > > { "Toshiba CD-ROM XM-6202B" , "ALL" }, > >+ { "TOSHIBA CD-ROM XM-1702BC" , "ALL" }, > > { "CD-532E-A" , "ALL" }, > > { "E-IDE CD-ROM CR-840", "ALL" }, > > { "CD-ROM Drive/F5A", "ALL" }, > > > When touching the blacklist, always make sure to patch > ata_dma_blacklist[] (drivers/scsi/libata-core.c) in the same patch (or > aonther patch mailed at the same time). > > Jeff thanks to pinpoint that. i'll send in a second patch covering the ata_dma_blacklist[]. -- maks ^ permalink raw reply [flat|nested] 9+ messages in thread
* [patch] libata dma blacklist toshiba cdrom drive 2005-06-26 17:44 ` Jeff Garzik 2005-06-26 17:48 ` maximilian attems @ 2005-06-26 18:01 ` maximilian attems 2005-06-27 7:24 ` [patch] ide dma blacklist toshiba Jens Axboe 2 siblings, 0 replies; 9+ messages in thread From: maximilian attems @ 2005-06-26 18:01 UTC (permalink / raw) To: Jeff Garzik; +Cc: B.Zolnierkiewicz, linux-ide, Herbert Xu blacklist "TOSHIBA CD-ROM XM-1702BC" bug reporter couldn't acces it's cdrom drive otherwise seperate patch from Herbert Xu adds it to drive_blacklist[] in drivers/ide/ide-dma.c Signed-off-by: maximilian attems <janitor@sternwelten.at> --- a/drivers/scsi/libata-core.c.orig 2005-06-26 19:51:10.769825568 +0200 +++ b/drivers/scsi/libata-core.c 2005-06-26 19:52:04.849967051 +0200 @@ -1920,6 +1920,7 @@ static const char * ata_dma_blacklist [] "HITACHI CDR-8335", "HITACHI CDR-8435", "Toshiba CD-ROM XM-6202B", + "TOSHIBA CD-ROM XM-1702BC", "CD-532E-A", "E-IDE CD-ROM CR-840", "CD-ROM Drive/F5A", ^ permalink raw reply [flat|nested] 9+ messages in thread
* Re: [patch] ide dma blacklist toshiba 2005-06-26 17:44 ` Jeff Garzik 2005-06-26 17:48 ` maximilian attems 2005-06-26 18:01 ` [patch] libata dma blacklist toshiba cdrom drive maximilian attems @ 2005-06-27 7:24 ` Jens Axboe 2005-06-28 4:01 ` Jeff Garzik 2 siblings, 1 reply; 9+ messages in thread From: Jens Axboe @ 2005-06-27 7:24 UTC (permalink / raw) To: Jeff Garzik; +Cc: maximilian attems, B.Zolnierkiewicz, linux-ide, Herbert Xu On Sun, Jun 26 2005, Jeff Garzik wrote: > maximilian attems wrote: > >--- kernel-source-2.6.6/drivers/ide/ide-dma.c 2004-04-05 > >19:49:28.000000000 +1000 > >+++ kernel-source-2.6.6-1/drivers/ide/ide-dma.c 2004-04-05 > >20:54:34.000000000 +1000 > >@@ -125,6 +125,7 @@ > > { "HITACHI CDR-8335" , "ALL" }, > > { "HITACHI CDR-8435" , "ALL" }, > > { "Toshiba CD-ROM XM-6202B" , "ALL" }, > >+ { "TOSHIBA CD-ROM XM-1702BC" , "ALL" }, > > { "CD-532E-A" , "ALL" }, > > { "E-IDE CD-ROM CR-840", "ALL" }, > > { "CD-ROM Drive/F5A", "ALL" }, > > > When touching the blacklist, always make sure to patch > ata_dma_blacklist[] (drivers/scsi/libata-core.c) in the same patch (or > aonther patch mailed at the same time). This has come up at least two times in the last week already, how about adding a unified dma blacklist to ata.h instead? -- Jens Axboe ^ permalink raw reply [flat|nested] 9+ messages in thread
* Re: [patch] ide dma blacklist toshiba 2005-06-27 7:24 ` [patch] ide dma blacklist toshiba Jens Axboe @ 2005-06-28 4:01 ` Jeff Garzik 2005-06-28 6:27 ` Jens Axboe 0 siblings, 1 reply; 9+ messages in thread From: Jeff Garzik @ 2005-06-28 4:01 UTC (permalink / raw) To: Jens Axboe; +Cc: maximilian attems, B.Zolnierkiewicz, linux-ide, Herbert Xu Jens Axboe wrote: > On Sun, Jun 26 2005, Jeff Garzik wrote: > >>maximilian attems wrote: >> >>>--- kernel-source-2.6.6/drivers/ide/ide-dma.c 2004-04-05 >>>19:49:28.000000000 +1000 >>>+++ kernel-source-2.6.6-1/drivers/ide/ide-dma.c 2004-04-05 >>>20:54:34.000000000 +1000 >>>@@ -125,6 +125,7 @@ >>> { "HITACHI CDR-8335" , "ALL" }, >>> { "HITACHI CDR-8435" , "ALL" }, >>> { "Toshiba CD-ROM XM-6202B" , "ALL" }, >>>+ { "TOSHIBA CD-ROM XM-1702BC" , "ALL" }, >>> { "CD-532E-A" , "ALL" }, >>> { "E-IDE CD-ROM CR-840", "ALL" }, >>> { "CD-ROM Drive/F5A", "ALL" }, >> >> >>When touching the blacklist, always make sure to patch >>ata_dma_blacklist[] (drivers/scsi/libata-core.c) in the same patch (or >>aonther patch mailed at the same time). > > > This has come up at least two times in the last week already, how about > adding a unified dma blacklist to ata.h instead? Feel free to submit a patch :) Jeff ^ permalink raw reply [flat|nested] 9+ messages in thread
* Re: [patch] ide dma blacklist toshiba 2005-06-28 4:01 ` Jeff Garzik @ 2005-06-28 6:27 ` Jens Axboe 2005-06-28 7:41 ` maximilian attems 0 siblings, 1 reply; 9+ messages in thread From: Jens Axboe @ 2005-06-28 6:27 UTC (permalink / raw) To: Jeff Garzik; +Cc: maximilian attems, B.Zolnierkiewicz, linux-ide, Herbert Xu On Tue, Jun 28 2005, Jeff Garzik wrote: > Jens Axboe wrote: > >On Sun, Jun 26 2005, Jeff Garzik wrote: > > > >>maximilian attems wrote: > >> > >>>--- kernel-source-2.6.6/drivers/ide/ide-dma.c 2004-04-05 > >>>19:49:28.000000000 +1000 > >>>+++ kernel-source-2.6.6-1/drivers/ide/ide-dma.c 2004-04-05 > >>>20:54:34.000000000 +1000 > >>>@@ -125,6 +125,7 @@ > >>> { "HITACHI CDR-8335" , "ALL" }, > >>> { "HITACHI CDR-8435" , "ALL" }, > >>> { "Toshiba CD-ROM XM-6202B" , "ALL" }, > >>>+ { "TOSHIBA CD-ROM XM-1702BC" , "ALL" }, > >>> { "CD-532E-A" , "ALL" }, > >>> { "E-IDE CD-ROM CR-840", "ALL" }, > >>> { "CD-ROM Drive/F5A", "ALL" }, > >> > >> > >>When touching the blacklist, always make sure to patch > >>ata_dma_blacklist[] (drivers/scsi/libata-core.c) in the same patch (or > >>aonther patch mailed at the same time). > > > > > >This has come up at least two times in the last week already, how about > >adding a unified dma blacklist to ata.h instead? > > Feel free to submit a patch :) Hehe, somehow I knew that was going to be the response :-) -- Jens Axboe ^ permalink raw reply [flat|nested] 9+ messages in thread
* Re: [patch] ide dma blacklist toshiba 2005-06-28 6:27 ` Jens Axboe @ 2005-06-28 7:41 ` maximilian attems 2005-06-28 7:49 ` Jens Axboe 0 siblings, 1 reply; 9+ messages in thread From: maximilian attems @ 2005-06-28 7:41 UTC (permalink / raw) To: Jens Axboe; +Cc: Jeff Garzik, B.Zolnierkiewicz, linux-ide, Herbert Xu On Tue, 28 Jun 2005, Jens Axboe wrote: > On Tue, Jun 28 2005, Jeff Garzik wrote: > > Jens Axboe wrote: > > >On Sun, Jun 26 2005, Jeff Garzik wrote: > > > > > >>maximilian attems wrote: > > >> > > >>>--- kernel-source-2.6.6/drivers/ide/ide-dma.c 2004-04-05 > > >>>19:49:28.000000000 +1000 > > >>>+++ kernel-source-2.6.6-1/drivers/ide/ide-dma.c 2004-04-05 > > >>>20:54:34.000000000 +1000 > > >>>@@ -125,6 +125,7 @@ > > >>> { "HITACHI CDR-8335" , "ALL" }, > > >>> { "HITACHI CDR-8435" , "ALL" }, > > >>> { "Toshiba CD-ROM XM-6202B" , "ALL" }, > > >>>+ { "TOSHIBA CD-ROM XM-1702BC" , "ALL" }, > > >>> { "CD-532E-A" , "ALL" }, > > >>> { "E-IDE CD-ROM CR-840", "ALL" }, > > >>> { "CD-ROM Drive/F5A", "ALL" }, > > >> > > >> > > >>When touching the blacklist, always make sure to patch > > >>ata_dma_blacklist[] (drivers/scsi/libata-core.c) in the same patch (or > > >>aonther patch mailed at the same time). > > > > > > > > >This has come up at least two times in the last week already, how about > > >adding a unified dma blacklist to ata.h instead? > > > > Feel free to submit a patch :) > > Hehe, somehow I knew that was going to be the response :-) > > -- > Jens Axboe if you haven't done it yet, i'll spin one next weekend. -- maks ^ permalink raw reply [flat|nested] 9+ messages in thread
* Re: [patch] ide dma blacklist toshiba 2005-06-28 7:41 ` maximilian attems @ 2005-06-28 7:49 ` Jens Axboe 0 siblings, 0 replies; 9+ messages in thread From: Jens Axboe @ 2005-06-28 7:49 UTC (permalink / raw) To: maximilian attems; +Cc: Jeff Garzik, B.Zolnierkiewicz, linux-ide, Herbert Xu On Tue, Jun 28 2005, maximilian attems wrote: > On Tue, 28 Jun 2005, Jens Axboe wrote: > > > On Tue, Jun 28 2005, Jeff Garzik wrote: > > > Jens Axboe wrote: > > > >On Sun, Jun 26 2005, Jeff Garzik wrote: > > > > > > > >>maximilian attems wrote: > > > >> > > > >>>--- kernel-source-2.6.6/drivers/ide/ide-dma.c 2004-04-05 > > > >>>19:49:28.000000000 +1000 > > > >>>+++ kernel-source-2.6.6-1/drivers/ide/ide-dma.c 2004-04-05 > > > >>>20:54:34.000000000 +1000 > > > >>>@@ -125,6 +125,7 @@ > > > >>> { "HITACHI CDR-8335" , "ALL" }, > > > >>> { "HITACHI CDR-8435" , "ALL" }, > > > >>> { "Toshiba CD-ROM XM-6202B" , "ALL" }, > > > >>>+ { "TOSHIBA CD-ROM XM-1702BC" , "ALL" }, > > > >>> { "CD-532E-A" , "ALL" }, > > > >>> { "E-IDE CD-ROM CR-840", "ALL" }, > > > >>> { "CD-ROM Drive/F5A", "ALL" }, > > > >> > > > >> > > > >>When touching the blacklist, always make sure to patch > > > >>ata_dma_blacklist[] (drivers/scsi/libata-core.c) in the same patch (or > > > >>aonther patch mailed at the same time). > > > > > > > > > > > >This has come up at least two times in the last week already, how about > > > >adding a unified dma blacklist to ata.h instead? > > > > > > Feel free to submit a patch :) > > > > Hehe, somehow I knew that was going to be the response :-) > > > > -- > > Jens Axboe > > if you haven't done it yet, i'll spin one next weekend. Feel free, thanks. -- Jens Axboe ^ permalink raw reply [flat|nested] 9+ messages in thread
end of thread, other threads:[~2005-06-28 7:47 UTC | newest] Thread overview: 9+ messages (download: mbox.gz follow: Atom feed -- links below jump to the message on this page -- 2005-06-26 16:55 [patch] ide dma blacklist toshiba maximilian attems 2005-06-26 17:44 ` Jeff Garzik 2005-06-26 17:48 ` maximilian attems 2005-06-26 18:01 ` [patch] libata dma blacklist toshiba cdrom drive maximilian attems 2005-06-27 7:24 ` [patch] ide dma blacklist toshiba Jens Axboe 2005-06-28 4:01 ` Jeff Garzik 2005-06-28 6:27 ` Jens Axboe 2005-06-28 7:41 ` maximilian attems 2005-06-28 7:49 ` Jens Axboe
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox; as well as URLs for NNTP newsgroup(s).