* [2.6 patch] SCSI_SATA has to be a tristate
@ 2005-07-15 21:35 Adrian Bunk
0 siblings, 0 replies; 7+ messages in thread
From: Adrian Bunk @ 2005-07-15 21:35 UTC (permalink / raw)
To: Andrew Morton; +Cc: jgarzik, linux-kernel, linux-ide
SCSI=m must disallow static drivers.
The problem is that all the SATA drivers depend on SCSI_SATA.
With SCSI=m and SCSI_SATA=y this allows the static enabling of the SATA
drivers with unwanted effects, e.g.:
- SCSI=m, SCSI_SATA=y, SCSI_ATA_ADMA=y
-> SCSI_ATA_ADMA is built statically but scsi/built-in.o is not linked
into the kernel
- SCSI=m, SCSI_SATA=y, SCSI_ATA_ADMA=y, SCSI_SATA_AHCI=m
-> SCSI_ATA_ADMA and libata are built statically but
scsi/built-in.o is not linked into the kernel,
SCSI_SATA_AHCI is built modular (unresolved symbols due to missing
libata)
Signed-off-by: Adrian Bunk <bunk@stusta.de>
---
This patch was already sent on:
- 8 Jul 2005
- 2 Jul 2005
--- linux-2.6.13-rc1-mm1/drivers/scsi/Kconfig.old 2005-07-02 21:57:40.000000000 +0200
+++ linux-2.6.13-rc1-mm1/drivers/scsi/Kconfig 2005-07-02 21:58:06.000000000 +0200
@@ -447,7 +447,7 @@
source "drivers/scsi/megaraid/Kconfig.megaraid"
config SCSI_SATA
- bool "Serial ATA (SATA) support"
+ tristate "Serial ATA (SATA) support"
depends on SCSI
help
This driver family supports Serial ATA host controllers
k
^ permalink raw reply [flat|nested] 7+ messages in thread* [2.6 patch] SCSI_SATA has to be a tristate
@ 2005-07-08 21:48 Adrian Bunk
2005-07-08 23:36 ` Roman Zippel
0 siblings, 1 reply; 7+ messages in thread
From: Adrian Bunk @ 2005-07-08 21:48 UTC (permalink / raw)
To: Andrew Morton; +Cc: jgarzik, linux-kernel, linux-ide
SCSI=m must disallow static drivers.
Signed-off-by: Adrian Bunk <bunk@stusta.de>
---
This patch was already sent on:
- 2 Jul 2005
--- linux-2.6.13-rc1-mm1/drivers/scsi/Kconfig.old 2005-07-02 21:57:40.000000000 +0200
+++ linux-2.6.13-rc1-mm1/drivers/scsi/Kconfig 2005-07-02 21:58:06.000000000 +0200
@@ -447,7 +447,7 @@
source "drivers/scsi/megaraid/Kconfig.megaraid"
config SCSI_SATA
- bool "Serial ATA (SATA) support"
+ tristate "Serial ATA (SATA) support"
depends on SCSI
help
This driver family supports Serial ATA host controllers
^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: [2.6 patch] SCSI_SATA has to be a tristate
2005-07-08 21:48 Adrian Bunk
@ 2005-07-08 23:36 ` Roman Zippel
2005-07-09 0:05 ` Jeff Garzik
2005-07-09 1:24 ` Adrian Bunk
0 siblings, 2 replies; 7+ messages in thread
From: Roman Zippel @ 2005-07-08 23:36 UTC (permalink / raw)
To: Adrian Bunk; +Cc: Andrew Morton, jgarzik, linux-kernel, linux-ide
Hi,
On Fri, 8 Jul 2005, Adrian Bunk wrote:
> --- linux-2.6.13-rc1-mm1/drivers/scsi/Kconfig.old 2005-07-02 21:57:40.000000000 +0200
> +++ linux-2.6.13-rc1-mm1/drivers/scsi/Kconfig 2005-07-02 21:58:06.000000000 +0200
> @@ -447,7 +447,7 @@
> source "drivers/scsi/megaraid/Kconfig.megaraid"
>
> config SCSI_SATA
> - bool "Serial ATA (SATA) support"
> + tristate "Serial ATA (SATA) support"
> depends on SCSI
> help
> This driver family supports Serial ATA host controllers
Did you verify that this works?
Overwise "depends on SCSI=y" might also be correct.
bye, Roman
^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: [2.6 patch] SCSI_SATA has to be a tristate
2005-07-08 23:36 ` Roman Zippel
@ 2005-07-09 0:05 ` Jeff Garzik
2005-07-09 1:24 ` Adrian Bunk
1 sibling, 0 replies; 7+ messages in thread
From: Jeff Garzik @ 2005-07-09 0:05 UTC (permalink / raw)
To: Roman Zippel; +Cc: Adrian Bunk, Andrew Morton, linux-kernel, linux-ide
Roman Zippel wrote:
> Hi,
>
> On Fri, 8 Jul 2005, Adrian Bunk wrote:
>
>
>>--- linux-2.6.13-rc1-mm1/drivers/scsi/Kconfig.old 2005-07-02 21:57:40.000000000 +0200
>>+++ linux-2.6.13-rc1-mm1/drivers/scsi/Kconfig 2005-07-02 21:58:06.000000000 +0200
>>@@ -447,7 +447,7 @@
>> source "drivers/scsi/megaraid/Kconfig.megaraid"
>>
>> config SCSI_SATA
>>- bool "Serial ATA (SATA) support"
>>+ tristate "Serial ATA (SATA) support"
>> depends on SCSI
>> help
>> This driver family supports Serial ATA host controllers
>
>
> Did you verify that this works?
No, he didn't :)
This option needs to follow the rules for dep_mbool in 2.4.x. It should
not be a tristate, but it is dependent on a tristate.
Jeff
^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: [2.6 patch] SCSI_SATA has to be a tristate
2005-07-08 23:36 ` Roman Zippel
2005-07-09 0:05 ` Jeff Garzik
@ 2005-07-09 1:24 ` Adrian Bunk
1 sibling, 0 replies; 7+ messages in thread
From: Adrian Bunk @ 2005-07-09 1:24 UTC (permalink / raw)
To: Roman Zippel; +Cc: Andrew Morton, jgarzik, linux-kernel, linux-ide
On Sat, Jul 09, 2005 at 01:36:08AM +0200, Roman Zippel wrote:
> Hi,
>
> On Fri, 8 Jul 2005, Adrian Bunk wrote:
>
> > --- linux-2.6.13-rc1-mm1/drivers/scsi/Kconfig.old 2005-07-02 21:57:40.000000000 +0200
> > +++ linux-2.6.13-rc1-mm1/drivers/scsi/Kconfig 2005-07-02 21:58:06.000000000 +0200
> > @@ -447,7 +447,7 @@
> > source "drivers/scsi/megaraid/Kconfig.megaraid"
> >
> > config SCSI_SATA
> > - bool "Serial ATA (SATA) support"
> > + tristate "Serial ATA (SATA) support"
> > depends on SCSI
> > help
> > This driver family supports Serial ATA host controllers
>
> Did you verify that this works?
> Overwise "depends on SCSI=y" might also be correct.
Yes, I did.
The problem is that all the SATA drivers depend on SCSI_SATA.
With SCSI=m and SCSI_SATA=y this allows the static enabling of the SATA
drivers with unwanted effects, e.g.:
- SCSI=m, SCSI_SATA=y, SCSI_ATA_ADMA=y
-> SCSI_ATA_ADMA is built statically but scsi/built-in.o is not linked
into the kernel
- SCSI=m, SCSI_SATA=y, SCSI_ATA_ADMA=y, SCSI_SATA_AHCI=m
-> SCSI_ATA_ADMA and libata are built statically but
scsi/built-in.o is not linked into the kernel,
SCSI_SATA_AHCI is built modular (unresolved symbols due to missing
libata)
Making SCSI_SATA a tristate solves all these problems.
"depends on SCSI=y" would also solve these problems, but it would leave
people with modular SCSI without SATA support...
> bye, Roman
cu
Adrian
--
"Is there not promise of rain?" Ling Tan asked suddenly out
of the darkness. There had been need of rain for many days.
"Only a promise," Lao Er said.
Pearl S. Buck - Dragon Seed
^ permalink raw reply [flat|nested] 7+ messages in thread
[parent not found: <42C6C5CE.50203@freemail.hu>]
* [2.6 patch] SCSI_SATA has to be a tristate
[not found] <42C6C5CE.50203@freemail.hu>
@ 2005-07-02 21:43 ` Adrian Bunk
2005-07-03 14:01 ` Zoltan Boszormenyi
0 siblings, 1 reply; 7+ messages in thread
From: Adrian Bunk @ 2005-07-02 21:43 UTC (permalink / raw)
To: Zoltan Boszormenyi, jgarzik; +Cc: linux-kernel, linux-ide
On Sat, Jul 02, 2005 at 06:50:22PM +0200, Zoltan Boszormenyi wrote:
> Hi!
Hi Zoltan!
> I got this, the tree is freshly untarred and patched:
>
> BUILD arch/x86_64/boot/bzImage
> Root device is (3, 10)
> Boot sector 512 bytes.
> Setup is 7249 bytes.
> System is 1586 kB
> Kernel: arch/x86_64/boot/bzImage is ready
> Building modules, stage 2.
> MODPOST
> *** Warning: "is_broadcast_ether_addr" [net/ieee80211/ieee80211.ko]
> undefined!
Known bug, fix was already posted.
> *** Warning: "ata_device_add" [drivers/scsi/sata_vsc.ko] undefined!
>...
> .config is attached.
Thanks for this report, the fix is below.
> Best regards,
> Zoltán Böszörményi
cu
Adrian
<-- snip -->
SCSI=m must disallow static drivers.
Signed-off-by: Adrian Bunk <bunk@stusta.de>
--- linux-2.6.13-rc1-mm1/drivers/scsi/Kconfig.old 2005-07-02 21:57:40.000000000 +0200
+++ linux-2.6.13-rc1-mm1/drivers/scsi/Kconfig 2005-07-02 21:58:06.000000000 +0200
@@ -447,7 +447,7 @@
source "drivers/scsi/megaraid/Kconfig.megaraid"
config SCSI_SATA
- bool "Serial ATA (SATA) support"
+ tristate "Serial ATA (SATA) support"
depends on SCSI
help
This driver family supports Serial ATA host controllers
^ permalink raw reply [flat|nested] 7+ messages in thread
end of thread, other threads:[~2005-07-15 21:35 UTC | newest]
Thread overview: 7+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2005-07-15 21:35 [2.6 patch] SCSI_SATA has to be a tristate Adrian Bunk
-- strict thread matches above, loose matches on Subject: below --
2005-07-08 21:48 Adrian Bunk
2005-07-08 23:36 ` Roman Zippel
2005-07-09 0:05 ` Jeff Garzik
2005-07-09 1:24 ` Adrian Bunk
[not found] <42C6C5CE.50203@freemail.hu>
2005-07-02 21:43 ` Adrian Bunk
2005-07-03 14:01 ` Zoltan Boszormenyi
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).