Re: [git patches] 2.4.x SATA update

[Sergey Vlasov <vsu@altlinux.ru>]

[-- Attachment #1: Type: text/plain, Size: 1530 bytes --]

On Thu, 28 Jul 2005 15:46:32 -0400 Jeff Garzik wrote:

> +/**
> + *	ata_sg_init_one - Associate command with memory buffer
> + *	@qc: Command to be associated
> + *	@buf: Memory buffer
> + *	@buflen: Length of memory buffer, in bytes.
> + *
> + *	Initialize the data-related elements of queued_cmd @qc
> + *	to point to a single memory buffer, @buf of byte length @buflen.
> + *
> + *	LOCKING:
> + *	spin_lock_irqsave(host_set lock)
> + */
> +
> +
> +
> +/**
> + *	ata_sg_init_one - Prepare a one-entry scatter-gather list.
> + *	@qc:  Queued command
> + *	@buf:  transfer buffer
> + *	@buflen:  length of buf
> + *
> + *	Builds a single-entry scatter-gather list to initiate a
> + *	transfer utilizing the specified buffer.
> + *
> + *	LOCKING:
> + */

Which one of the above duplicated comments for ata_sg_init_one is
correct?

> +/**
> + *	ata_sg_init - Associate command with scatter-gather table.
> + *	@qc: Command to be associated
> + *	@sg: Scatter-gather table.
> + *	@n_elem: Number of elements in s/g table.
> + *
> + *	Initialize the data-related elements of queued_cmd @qc
> + *	to point to a scatter-gather table @sg, containing @n_elem
> + *	elements.
> + *
> + *	LOCKING:
> + *	spin_lock_irqsave(host_set lock)
> + */
> +
> +
> +/**
> + *	ata_sg_init - Assign a scatter gather list to a queued command
> + *	@qc:  Queued command
> + *	@sg:  Scatter-gather list
> + *	@n_elem:  length of sg list
> + *
> + *	Attaches a scatter-gather list to a queued command.
> + *
> + *	LOCKING:
> + */

More duplicated comments.

[-- Attachment #2: Type: application/pgp-signature, Size: 189 bytes --]