From: Jens Axboe <axboe@suse.de>
To: Martin Wilck <martin.wilck@fujitsu-siemens.com>
Cc: linux-kernel@vger.kernel.org, Jeff Garzik <jgarzik@pobox.com>,
linux-ide@vger.kernel.org, "Wichert,
Gerhard" <Gerhard.Wichert@fujitsu-siemens.com>
Subject: Re: ahci, SActive flag, and the HD activity LED
Date: Wed, 3 Aug 2005 08:19:22 +0200 [thread overview]
Message-ID: <20050803061917.GE3710@suse.de> (raw)
In-Reply-To: <42F05359.7030006@fujitsu-siemens.com>
On Wed, Aug 03 2005, Martin Wilck wrote:
> Jens Axboe wrote:
>
> >>If I am reading the specs correctly, that'd mean the ahci driver is
> >>wrong in setting the SActive bit.
> >
> >I completely agree, that was my reading of the spec as well and hence my
> >original posts about this in the NCQ thread.
>
> Have you (or has anybody else) also seen the wrong behavior of the
> activity LED?
No, but I have observed that SActive never gets cleared by the device
for non-NCQ commands (which is probably which gets you the stuck LED on
some systems?), which to me is another indication that we should not be
setting the tag bits for those commands.
--
Jens Axboe
next prev parent reply other threads:[~2005-08-03 6:17 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2005-08-02 15:40 ahci, SActive flag, and the HD activity LED Martin Wilck
2005-08-02 16:35 ` Jens Axboe
2005-08-03 5:17 ` Martin Wilck
2005-08-03 6:19 ` Jens Axboe [this message]
2005-08-04 23:49 ` Eric D. Mudama
2005-08-03 6:41 ` Pasi Kärkkäinen
2005-08-03 11:08 ` André Tomt
2005-08-03 18:12 ` Adam Goode
2005-08-04 7:04 ` [PATCH] Fix HD activity LED with ahci Martin Wilck
2005-08-22 4:35 ` Jeff Garzik
2005-08-26 12:59 ` Martin Wilck
2005-08-23 5:03 ` Jeff Garzik
2005-08-03 19:21 ` ahci, SActive flag, and the HD activity LED Matthias Schniedermeyer
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20050803061917.GE3710@suse.de \
--to=axboe@suse.de \
--cc=Gerhard.Wichert@fujitsu-siemens.com \
--cc=jgarzik@pobox.com \
--cc=linux-ide@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=martin.wilck@fujitsu-siemens.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).