From: Tejun Heo <htejun@gmail.com>
To: jgarzik@pobox.com, efalk@google.com, Carlos.Pardo@siliconimage.com
Cc: linux-ide@vger.kernel.org
Subject: Re: [PATCH libata-dev-2.6:sil24 03/08] sil24: add testing for PCI fault
Date: Wed, 17 Aug 2005 13:08:52 +0900 (KST) [thread overview]
Message-ID: <20050817040611.8772AD4E@htj.dyndns.org> (raw)
In-Reply-To: <20050817040611.C0A53974@htj.dyndns.org>
03_sil24_add-pci-fault-check.patch
On entry to interrupt handler, PORT_SLOT_STAT register is read
first. Check if PCI fault or device removal has occurred by
testing the value for 0xffffffff.
Signed-off-by: Tejun Heo <htejun@gmail.com>
sata_sil24.c | 6 ++++++
1 files changed, 6 insertions(+)
Index: work/drivers/scsi/sata_sil24.c
===================================================================
--- work.orig/drivers/scsi/sata_sil24.c 2005-08-17 13:06:07.000000000 +0900
+++ work/drivers/scsi/sata_sil24.c 2005-08-17 13:06:07.000000000 +0900
@@ -527,6 +527,12 @@ static irqreturn_t sil24_interrupt(int i
status = readl(hpriv->host_base + HOST_IRQ_STAT);
+ if (status == 0xffffffff) {
+ printk(KERN_ERR DRV_NAME ": IRQ status == 0xffffffff, "
+ "PCI fault or device removal?\n");
+ goto out;
+ }
+
if (!(status & IRQ_STAT_4PORTS))
goto out;
next prev parent reply other threads:[~2005-08-17 4:08 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2005-08-17 4:08 [PATCH libata-dev-2.6:sil24 00/08] sil24: misc patches Tejun Heo
2005-08-17 4:08 ` [PATCH libata-dev-2.6:sil24 01/08] sil24: add FIXME comment above ata_device_add Tejun Heo
2005-08-17 4:52 ` Jeff Garzik
2005-08-17 4:08 ` [PATCH libata-dev-2.6:sil24 02/08] sil24: remove irq disable code on spurious interrupt Tejun Heo
2005-08-17 4:08 ` Tejun Heo [this message]
2005-08-17 4:08 ` [PATCH libata-dev-2.6:sil24 04/08] sil24: move error handling out of hot interrupt path Tejun Heo
2005-08-17 4:09 ` [PATCH libata-dev-2.6:sil24 05/08] sil24: remove PORT_TF Tejun Heo
2005-08-17 4:09 ` [PATCH libata-dev-2.6:sil24 06/08] sil24: replace pp->port w/ ap->ioaddr.cmd_addr Tejun Heo
2005-08-17 4:09 ` [PATCH libata-dev-2.6:sil24 07/08] sil24: fix PORT_CTRL_STAT constants Tejun Heo
2005-08-17 4:09 ` [PATCH libata-dev-2.6:sil24 08/08] sil24: add more comments for constants Tejun Heo
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20050817040611.8772AD4E@htj.dyndns.org \
--to=htejun@gmail.com \
--cc=Carlos.Pardo@siliconimage.com \
--cc=efalk@google.com \
--cc=jgarzik@pobox.com \
--cc=linux-ide@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).