Re: #undef ATA_ENABLE_PATA

[Horms <horms@verge.net.au>]

On Fri, Aug 26, 2005 at 12:55:23AM -0400, Jeff Garzik wrote:
> Horms wrote:
> >Hi Jeff, Hi All,
> >
> >In the cause of debuging a problem with a DVD burner[1]
> >Brett Smith brought to my attention that there are several
> >variables in ./include/linux/libata.h, that when changed
> >from #undef to #define, enable features in the ATA subsystem.
> >
> >Is there any interest in a patch to make any/all of these configurable
> >through Kconfig, or are they too hackish/dangerous/whatever to consider.
> >I'm more than happy to make a patch if there is interest, please let me
> >know wither way.
> >
> >Specifically, I am refering to:
> >
> >/*
> > * compile-time options
> > */
> >#undef ATA_DEBUG                /* debugging output */
> >#undef ATA_VERBOSE_DEBUG        /* yet more debugging output */
> 
> These should go away, once ATA_MSG_xxx is implemented (a la NETIF_MSG_xxx).
> 
> 
> >#undef ATA_IRQ_TRAP             /* define to ack screaming irqs */
> >#undef ATA_NDEBUG               /* define to disable quick runtime checks 
> >*/
> >#undef ATA_ENABLE_ATAPI         /* define to enable ATAPI support */
> >#undef ATA_ENABLE_PATA          /* define to enable PATA support in some
> >                                 * low-level drivers */
> >#undef ATAPI_ENABLE_DMADIR      /* enables ATAPI DMADIR bridge support */
> 
> These are all things that are either incomplete, or should not be 
> configured by non-developers.
> 
> When something is safe to turn on in the upstream kernel, it gets turned 
> on :)  This is why ATAPI defaults to off, even though some silly distros 
> turn it on.

Thanks Jeff, I suspected something along those lines.

-- 
Horms