From: linux@horizon.com
To: hch@infradead.org, linux-ide@vger.kernel.org, russb@emc.com
Subject: Re: [PATCH 2.6.13] libata: Marvell SATA support (PIO mode)
Date: 1 Sep 2005 16:19:31 -0400 [thread overview]
Message-ID: <20050901201931.32178.qmail@science.horizon.com> (raw)
>> +static inline void writelfl(unsigned long data, void __iomem *addr)
>> +{
>> + writel(data, addr);
>> + (void) readl(addr); /* flush */
>
> no need for the (void) case.
Not strictly necessary, but a redundant (void) cast is a pretty standard
way of documenting "yes, I really mean to ignore the return value."
I'd like to suggest that it's helpful to the reader and should stay.
(Maybe even, for those who don't know, change the comment to
"Standard PCI flush trick.")
On your other style comments, I agree.
Well, except that "braces" are {}, while () are "parentheses" or "parens".
next reply other threads:[~2005-09-01 20:19 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2005-09-01 20:19 linux [this message]
-- strict thread matches above, loose matches on Subject: below --
2005-08-30 18:36 [RFC][PATCH 2.6.13] Marvell SATA support (PIO mode) Brett Russ
2005-08-30 20:48 ` Jeff Garzik
2005-09-01 14:27 ` [PATCH 2.6.13] libata: " Brett Russ
2005-09-01 14:40 ` Christoph Hellwig
2005-09-01 19:48 ` Jeff Garzik
2005-09-01 19:58 ` Christoph Hellwig
2005-09-01 20:03 ` Jeff Garzik
2005-09-01 20:04 ` Jeff Garzik
2005-09-01 20:05 ` Christoph Hellwig
2005-09-01 20:28 ` Jeff Garzik
2005-09-01 22:26 ` Brett Russ
2005-09-02 1:32 ` Brett Russ
2005-09-02 17:16 ` Bogdan Costescu
2005-09-02 17:55 ` Ray Lee
2005-09-07 5:56 ` Jeff Garzik
2005-09-07 14:40 ` Brett Russ
2005-09-07 16:31 ` Bogdan Costescu
2005-09-03 14:08 ` Tyler
2005-09-03 17:29 ` Jeff Garzik
2005-09-27 5:36 ` Tyler
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20050901201931.32178.qmail@science.horizon.com \
--to=linux@horizon.com \
--cc=hch@infradead.org \
--cc=linux-ide@vger.kernel.org \
--cc=russb@emc.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).