From: Pavel Machek <pavel@suse.cz>
To: Jeff Garzik <jgarzik@pobox.com>
Cc: Joshua Kwan <joshk@triplehelix.org>,
axboe@suse.de, Linux Kernel <linux-kernel@vger.kernel.org>,
"linux-ide@vger.kernel.org" <linux-ide@vger.kernel.org>,
Andrew Morton <akpm@osdl.org>
Subject: Re: SATA suspend-to-ram patch - merge?
Date: Thu, 22 Sep 2005 12:36:06 +0200 [thread overview]
Message-ID: <20050922103605.GA1527@openzaurus.ucw.cz> (raw)
In-Reply-To: <433221A1.5000600@pobox.com>
Hi!
> >Is Jens' patch still relevant? If so, should it be rediffed and
> >merged
> >into mainline? It doesn't seem to cause any weird side-effects.
> >
> >More importantly, I would be inclined to properly rediff Jens' patch
> >and
> >merge it into Debian 2.6.12 kernel sources if there aren't any such
> >side-effects, since it benefits everyone using SATA and
> >suspend-to-ram
> >(that is, users of relatively modern laptops.)
>
> Jens' patch is technical correct for SATA, but really we want to do
> more stuff at the SCSI layer (see James Bottomley's response to Jens'
> patch).
>
> Unfortunately, this also implies that we have to figure out which
> SCSI devices are available to be power-managed, and which SCSI
> devices are on a shared bus that should never be suspended.
I think that shared buses are rare enough to be safely ignored.
We could simply say "never ever suspend machine with some
disks on shared bus".
Pavel
--
64 bytes from 195.113.31.123: icmp_seq=28 ttl=51 time=448769.1 ms
next prev parent reply other threads:[~2005-09-24 9:57 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <433104E0.4090308@triplehelix.org>
2005-09-22 3:14 ` SATA suspend-to-ram patch - merge? Jeff Garzik
2005-09-22 6:18 ` Jens Axboe
2005-09-22 13:04 ` Mark Lord
2005-09-22 13:08 ` Matthew Garrett
2005-09-22 13:24 ` Jens Axboe
2005-09-22 13:24 ` Jens Axboe
2005-09-22 14:28 ` Christoph Hellwig
2005-09-22 14:17 ` Alan Cox
2005-09-22 13:56 ` Jens Axboe
2005-09-22 14:30 ` Alan Cox
2005-09-22 14:20 ` Luben Tuikov
2005-09-22 17:57 ` Jeff Garzik
2005-09-22 18:04 ` Linus Torvalds
2005-09-22 18:08 ` Christoph Hellwig
2005-09-22 18:11 ` Jens Axboe
2005-09-22 15:01 ` Randy.Dunlap
2005-09-22 10:36 ` Pavel Machek [this message]
2005-09-24 10:18 ` Jeff Garzik
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20050922103605.GA1527@openzaurus.ucw.cz \
--to=pavel@suse.cz \
--cc=akpm@osdl.org \
--cc=axboe@suse.de \
--cc=jgarzik@pobox.com \
--cc=joshk@triplehelix.org \
--cc=linux-ide@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).