From: Erik Andersen <andersen@codepoet.org>
To: Jesper Juhl <jesper.juhl@gmail.com>
Cc: Jens Axboe <axboe@suse.de>, Alexey Dobriyan <adobriyan@gmail.com>,
linux-kernel@vger.kernel.org, linux-ide@vger.kernel.org
Subject: Re: [PATCH] ide-cd mini cleanup of casts (mainly)
Date: Tue, 4 Oct 2005 17:43:24 -0600 [thread overview]
Message-ID: <20051004234323.GA7045@codepoet.org> (raw)
In-Reply-To: <200510050019.44256.jesper.juhl@gmail.com>
On Wed Oct 05, 2005 at 12:19:43AM +0200, Jesper Juhl wrote:
> On Tuesday 04 October 2005 08:21, Jens Axboe wrote:
> [snip]
> > This is a mess. So NACK on this patch. And why are you changing the
> [snip]
>
> Hi Jens,
>
> Sorry about the messy previous patch. Would you consider something like the
> one below instead? It only makes a few changes, not lots of different ones in
> the same patch and it also only makes changes that I hope you'll agree are
> useful. :)
>
>
> Remove some unneeded casts.
> Avoid an assignment in the case of kmalloc failure.
> Break a few instances of if (foo) whatever; into two lines.
Revised patch looks ok to me. I stopped maintaining this
code years ago, but since I was CC'd...
-Erik
--
Erik B. Andersen http://codepoet-consulting.com/
--This message was written using 73% post-consumer electrons--
next prev parent reply other threads:[~2005-10-05 0:41 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2005-10-03 22:17 [PATCH] ide-cd cleanup (casts, whitespace and codingstyle) Jesper Juhl
2005-10-03 23:04 ` Alexey Dobriyan
2005-10-03 22:57 ` Jesper Juhl
2005-10-04 6:21 ` Jens Axboe
2005-10-04 9:28 ` Jesper Juhl
2005-10-04 22:19 ` [PATCH] ide-cd mini cleanup of casts (mainly) Jesper Juhl
2005-10-04 23:43 ` Erik Andersen [this message]
2005-10-05 11:34 ` Jens Axboe
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20051004234323.GA7045@codepoet.org \
--to=andersen@codepoet.org \
--cc=adobriyan@gmail.com \
--cc=axboe@suse.de \
--cc=jesper.juhl@gmail.com \
--cc=linux-ide@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).