From: Tejun Heo <htejun@gmail.com>
To: Jeff Garzik <jgarzik@pobox.com>, efalk@google.com
Cc: linux-ide@vger.kernel.org
Subject: [PATCH libata-dev-2.6:sil24] nit pickings
Date: Sat, 8 Oct 2005 12:10:43 +0900 [thread overview]
Message-ID: <20051008031043.GA13957@htj.dyndns.org> (raw)
Hello, Jeff & Edward.
This patch removes unused NR_PORTS macro and adds termination entry
to sil24_pci_tbl.
Signed-off-by: Tejun Heo <htejun@gmail.com>
diff --git a/drivers/scsi/sata_sil24.c b/drivers/scsi/sata_sil24.c
--- a/drivers/scsi/sata_sil24.c
+++ b/drivers/scsi/sata_sil24.c
@@ -43,8 +43,6 @@
#define DRV_NAME "sata_sil24"
#define DRV_VERSION "0.21" /* Silicon Image's preview driver was 0.10 */
-#define NR_PORTS 4
-
/*
* Port request block (PRB) 32 bytes
*/
@@ -244,6 +242,7 @@ static int sil24_init_one(struct pci_dev
static struct pci_device_id sil24_pci_tbl[] = {
{ 0x1095, 0x3124, PCI_ANY_ID, PCI_ANY_ID, 0, 0, BID_SIL3124 },
{ 0x1095, 0x3132, PCI_ANY_ID, PCI_ANY_ID, 0, 0, BID_SIL3132 },
+ { } /* terminate list */
};
static struct pci_driver sil24_pci_driver = {
next reply other threads:[~2005-10-08 3:10 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2005-10-08 3:10 Tejun Heo [this message]
2005-10-09 13:27 ` [PATCH libata-dev-2.6:sil24] nit pickings Jeff Garzik
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20051008031043.GA13957@htj.dyndns.org \
--to=htejun@gmail.com \
--cc=efalk@google.com \
--cc=jgarzik@pobox.com \
--cc=linux-ide@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).