From: Jesse Barnes <jbarnes@virtuousgeek.org>
To: Jeff Garzik <jgarzik@pobox.com>
Cc: linux-kernel@vger.kernel.org, akpm@osdl.org,
"linux-ide@vger.kernel.org" <linux-ide@vger.kernel.org>
Subject: Re: Intel SATA combined mode quirk broken for SCSI_SATA=m
Date: Sun, 16 Oct 2005 19:48:27 -0700 [thread overview]
Message-ID: <200510161948.28154.jbarnes@virtuousgeek.org> (raw)
In-Reply-To: <43530D67.6020209@pobox.com>
[-- Attachment #1: Type: text/plain, Size: 695 bytes --]
On Sunday, October 16, 2005 7:33 pm, Jeff Garzik wrote:
> Overall the quirk is a hack until ATAPI is supported -- but even after
> ATAPI is supported, we need to figure out some way to keep IDE driver
> from stealing the legacy IDE ports before libata can touch them :(
>
> However, when ATAPI is supported, that at least means that both PATA and
> SATA can run at full speed.
But then can't we remove the quirk and just declare them incompatible (i.e.
who loads first, wins)?
> Your patch is correct, and should go into 2.6.14-rc post-haste.
Well, almost. :) I diffed against a bad version. This one should actually
apply.
Jesse
Signed-off-by: Jesse Barnes <jbarnes@virtuousgeek.org>
[-- Attachment #2: intel-combined-mode-quirk-hack.patch --]
[-- Type: text/x-diff, Size: 476 bytes --]
--- linux-2.6.14-rc4/drivers/pci/quirks.c.orig 2005-10-16 19:46:43.000000000 -0700
+++ linux-2.6.14-rc4/drivers/pci/quirks.c 2005-10-16 19:12:33.000000000 -0700
@@ -1233,7 +1233,7 @@
DECLARE_PCI_FIXUP_HEADER(PCI_VENDOR_ID_INTEL, PCI_DEVICE_ID_INTEL_EESSC, quirk_alder_ioapic );
#endif
-#ifdef CONFIG_SCSI_SATA
+#if defined(CONFIG_SCSI_SATA) || defined(CONFIG_SCSI_SATA_MODULE)
static void __devinit quirk_intel_ide_combined(struct pci_dev *pdev)
{
u8 prog, comb, tmp;
next prev parent reply other threads:[~2005-10-17 2:48 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <200510161913.59622.jbarnes@virtuousgeek.org>
2005-10-17 2:33 ` Intel SATA combined mode quirk broken for SCSI_SATA=m Jeff Garzik
2005-10-17 2:48 ` Jesse Barnes [this message]
2005-10-17 2:45 ` [PATCH] " Jeff Garzik
2005-10-17 2:55 ` Jesse Barnes
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=200510161948.28154.jbarnes@virtuousgeek.org \
--to=jbarnes@virtuousgeek.org \
--cc=akpm@osdl.org \
--cc=jgarzik@pobox.com \
--cc=linux-ide@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox