From: Jens Axboe <axboe@suse.de>
To: Timothy Thelin <Timothy.Thelin@wdc.com>
Cc: Bartlomiej Zolnierkiewicz <bzolnier@gmail.com>,
linux-ide@vger.kernel.org
Subject: Re: [UPDATED][PATCH 2.6.14]: ide: Enable larger taskfile transfers
Date: Tue, 1 Nov 2005 20:27:31 +0100 [thread overview]
Message-ID: <20051101192730.GJ26049@suse.de> (raw)
In-Reply-To: <CA45571DE57E1C45BF3552118BA92C9D69BF2C@WDSCEXBECL03.sc.wdc.com>
On Tue, Nov 01 2005, Timothy Thelin wrote:
> Changes:
> Increases the taskfile data transfer limit from 128K to a
> theoretical 2-4MB (arch dependant) by using __get_free_pages
> instead of kmalloc. Note that larger requests have a lower
> success rate because of needing to find a larger amount of
> free consecutive memory.
I don't think this is a good way to do it. IDE already supports sg for
regular fs requests, the correct solution would be to make sure the user
driven taskfile submission is sg based as well. That would enable large
transfers without risking allocation failures. An interface that doesn't
work for anything but a freshly booted kernel is pretty worthless, imho.
User interfaces must work predictably.
--
Jens Axboe
next prev parent reply other threads:[~2005-11-01 19:26 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2005-11-01 19:06 [UPDATED][PATCH 2.6.14]: ide: Enable larger taskfile transfers Timothy Thelin
2005-11-01 19:27 ` Jens Axboe [this message]
-- strict thread matches above, loose matches on Subject: below --
2005-11-01 19:17 Timothy Thelin
2005-11-01 20:24 Timothy Thelin
2005-11-02 8:49 ` Jens Axboe
2005-11-02 17:23 ` Martin Murray
2005-11-02 19:12 ` Bartlomiej Zolnierkiewicz
2005-11-03 21:43 ` Martin Murray
2005-11-02 20:42 Timothy Thelin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20051101192730.GJ26049@suse.de \
--to=axboe@suse.de \
--cc=Timothy.Thelin@wdc.com \
--cc=bzolnier@gmail.com \
--cc=linux-ide@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).