Re: [UPDATED][PATCH 2.6.14]: ide: Enable larger taskfile transfers

[Martin Murray <mmurray@deepthought.org>]

Just a few quick questions:

regarding HDIO_DRIVE_TASKFILE:
    I don't see any exact information, however, from what I can infer
from the code, it appears that while the user can specify an
input buffer and/or an output buffer, only one of the buffers would be
filled with useful information. Is it reasonable to assume that
req_task->out_size == 0 req_task->in_size == 0? Or, more specifically,
is it reasonable to return -EINVAL if both are non zero?

    If I were to do zero_copy IO using blk_rq_map_user, should I verify
the user buffer is valid with access_ok() ?

    Why does ide_diag_taskfile() allocate a custom request structure
instead of using blk_get_request(drive->queue, ...) ?

    Given HDIO_DRIVE_TASKFILE, what is the purpose of HDIO_DRIVE_TASK
and HDIO_DRIVE_CMD?

Thank you, Martin