linux-ide.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Jens Axboe <axboe@suse.de>
To: Jeff Garzik <jgarzik@pobox.com>
Cc: Spencer Tuttle <rodeojones@fastmail.fm>, linux-ide@vger.kernel.org
Subject: Re: Marvell MV88SX6041 SATA Driver PIO4 Mode Not DMA
Date: Fri, 11 Nov 2005 15:29:05 +0100	[thread overview]
Message-ID: <20051111142905.GV3699@suse.de> (raw)
In-Reply-To: <4374A4AC.8010007@pobox.com>

On Fri, Nov 11 2005, Jeff Garzik wrote:
> Jens Axboe wrote:
> >On Fri, Nov 11 2005, Jeff Garzik wrote:
> >
> >>Spencer Tuttle wrote:
> >>
> >>>I have just compiled the new 2.6.14 kernel from the gentoo-sources tree.
> >>>
> >>>I can access the drives just fine, but it seems really slow.  Here is
> >>>the dmesg output when I load the kernel module
> >>
> >>That's expected, since the driver in 2.6.14 only does PIO mode.
> >>
> >>Try 2.6.14-gitN which supports EDMA.
> >
> >
> >Did you see these as well:
> >
> >blk_queue_max_hw_segments: set to minimum 1
> >
> >Could it be forgetting to set ->sg_tablesize as well?
> 
> [jgarzik@sata linux-2.6]$ grep MV_MAX_SG_CT drivers/scsi/sata_mv.c
>         MV_MAX_SG_CT            = 176,
>         MV_SG_TBL_SZ            = (16 * MV_MAX_SG_CT),
>         .sg_tablesize           = MV_MAX_SG_CT,

It was just a guess, clearly someone is calling scsi_alloc_queue() with
an sdev->host->sg_tablesize of 0. While that wont make PIO a whole lot
faster, it's clearly a bug and would certainly hurt DMA performance.

-- 
Jens Axboe


  reply	other threads:[~2005-11-11 14:28 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2005-11-10 18:48 Marvell MV88SX6041 SATA Driver PIO4 Mode Not DMA Spencer Tuttle
2005-11-11 10:26 ` Jeff Garzik
2005-11-11 12:14   ` Jens Axboe
2005-11-11 14:03     ` Jeff Garzik
2005-11-11 14:29       ` Jens Axboe [this message]
2005-11-11 14:38         ` Jens Axboe
2005-11-11 17:08           ` Spencer Tuttle
2005-11-11 19:15             ` Spencer Tuttle
2005-11-14 21:35           ` Jeff Garzik
2005-11-15  7:57             ` Jens Axboe

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20051111142905.GV3699@suse.de \
    --to=axboe@suse.de \
    --cc=jgarzik@pobox.com \
    --cc=linux-ide@vger.kernel.org \
    --cc=rodeojones@fastmail.fm \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).