From: Randy Dunlap <randy_d_dunlap@linux.intel.com>
To: ide <linux-ide@vger.kernel.org>
Cc: axboe@suse.de, jgarzik@pobox.com
Subject: [PATCH 7/7] SATA ACPI debug-only output
Date: Tue, 13 Dec 2005 16:10:28 -0800 [thread overview]
Message-ID: <20051213161028.7b459b23.randy_d_dunlap@linux.intel.com> (raw)
In-Reply-To: <20051213160110.193e3f61.randy_d_dunlap@linux.intel.com>
From: Randy Dunlap <randy_d_dunlap@linux.intel.com>
Add some extra debug-only output.
Signed-off-by: Randy Dunlap <randy_d_dunlap@linux.intel.com>
---
drivers/scsi/ata_acpi.c | 17 ++++++++++++-----
drivers/scsi/libata-core.c | 6 +++---
2 files changed, 15 insertions(+), 8 deletions(-)
--- linux-2615-rc5g3.orig/drivers/scsi/ata_acpi.c
+++ linux-2615-rc5g3/drivers/scsi/ata_acpi.c
@@ -183,9 +183,10 @@ static int get_sata_adr(struct device *d
winfo->drivenum = drive;
status = acpi_get_devices(NULL, get_devices, winfo, NULL);
- if (ACPI_FAILURE(status))
+ if (ACPI_FAILURE(status)) {
+ DEBPRINT("acpi_get_devices failed\n");
err = -ENODEV;
- else {
+ } else {
*dev_adr = winfo->sata_adr;
atadev->obj_handle = winfo->obj_handle;
err = 0;
@@ -219,19 +220,25 @@ int do_drive_SDD(struct ata_port *ap, un
__FUNCTION__, ap->id, ix, ap->port_no, ap->hard_port_no);
/* Don't continue if not a SATA device. */
- if (!ata_id_is_sata(atadev->id))
+ if (!ata_id_is_sata(atadev->id)) {
+ DEBPRINT("ata_id_is_sata is False\n");
goto out;
+ }
/* Don't continue if device has no _ADR method.
* _SDD is intended for known motherboard devices. */
err = pci_acpi_get_dev_handle(dev, &handle, &pcidevfn);
- if (err < 0)
+ if (err < 0) {
+ DEBPRINT("get_dev_handle failed\n");
goto out;
+ }
/* Get this drive's _ADR info. */
dev_adr = SATA_ADR_RSVD;
err = get_sata_adr(dev, handle, pcidevfn, ix, ap, atadev, &dev_adr);
- if (err < 0 || dev_adr == SATA_ADR_RSVD || !atadev->obj_handle)
+ if (err < 0 || dev_adr == SATA_ADR_RSVD || !atadev->obj_handle) {
+ DEBPRINT("get_sata_adr failed\n");
goto out;
+ }
/* Give the drive Identify data to the drive via the _SDD method */
/* _SDD: set up input parameters */
--- linux-2615-rc5g3.orig/drivers/scsi/libata-core.c
+++ linux-2615-rc5g3/drivers/scsi/libata-core.c
@@ -1185,11 +1185,11 @@ retry:
/* print device capabilities */
printk(KERN_DEBUG "ata%u: dev %u cfg "
- "49:%04x 82:%04x 83:%04x 84:%04x 85:%04x 86:%04x 87:%04x 88:%04x\n",
- ap->id, device, dev->id[49],
+ "00:%04x 49:%04x 82:%04x 83:%04x 84:%04x 85:%04x 86:%04x 87:%04x 88:%04x 93:%04x\n",
+ ap->id, device, dev->id[0], dev->id[49],
dev->id[82], dev->id[83], dev->id[84],
dev->id[85], dev->id[86], dev->id[87],
- dev->id[88]);
+ dev->id[88], dev->id[93]);
/*
* common ATA, ATAPI feature tests
---
next prev parent reply other threads:[~2005-12-14 0:07 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20051213160110.193e3f61.randy_d_dunlap@linux.intel.com>
2005-12-14 0:02 ` [PATCH 1/7] SATA suspend/resume support (Jens) Randy Dunlap
2005-12-14 22:07 ` Jeff Garzik
2005-12-14 22:22 ` Randy Dunlap
2005-12-14 0:04 ` [PATCH 2/7] SATA ACPI make/config Randy Dunlap
2005-12-14 22:07 ` Jeff Garzik
2005-12-14 0:05 ` [PATCH 3/7] SATA ACPI linux/libata.h update Randy Dunlap
2005-12-14 22:08 ` Jeff Garzik
2005-12-14 23:00 ` Randy Dunlap
2005-12-14 0:06 ` [PATCH 4/7] call/invoke SATA ACPI suspend/resume functions Randy Dunlap
2005-12-14 22:11 ` Jeff Garzik
2005-12-14 0:07 ` [PATCH 5/7] SATA ACPI kernel-doc Randy Dunlap
2005-12-14 22:12 ` Jeff Garzik
2005-12-14 0:09 ` [PATCH 6/7] SATA ACPI suspend/resume functions Randy Dunlap
2005-12-14 22:23 ` Jeff Garzik
2005-12-14 0:10 ` Randy Dunlap [this message]
2005-12-14 22:23 ` [PATCH 7/7] SATA ACPI debug-only output Jeff Garzik
2005-12-14 22:42 ` Randy Dunlap
2005-12-14 22:42 ` Jeff Garzik
2005-12-14 23:08 ` Randy Dunlap
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20051213161028.7b459b23.randy_d_dunlap@linux.intel.com \
--to=randy_d_dunlap@linux.intel.com \
--cc=axboe@suse.de \
--cc=jgarzik@pobox.com \
--cc=linux-ide@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).