From: Jens Axboe <axboe@suse.de>
To: Randy Dunlap <randy_d_dunlap@linux.intel.com>
Cc: jhpark@tuhep.phys.tohoku.ac.jp, linux-ide@vger.kernel.org,
jgarzik@pobox.com, chris@powerblogs.com
Subject: Re: [PATCH 0/5] SATA/ACPI suspend/resume support
Date: Tue, 3 Jan 2006 21:06:03 +0100 [thread overview]
Message-ID: <20060103200603.GA3472@suse.de> (raw)
In-Reply-To: <20060103115712.5ac7ec47.randy_d_dunlap@linux.intel.com>
[-- Attachment #1: Type: text/plain, Size: 1380 bytes --]
On Tue, Jan 03 2006, Randy Dunlap wrote:
> > ata1: SATA max UDMA/133 cmd 0x1F0 ctl 0x3F6 bmdma 0x18C0 irq 14
> > ata1: dev 0 cfg 49:2f00 82:346b 83:7d09 84:6003 85:3469 86:3c09 87:6003
> > 88:203f
> > ata1: dev 0 ATA-7, max UDMA/100, 156301488 sectors: LBA48
> > ata1(0): applying bridge limits
> > ata1: dev 0 configured for UDMA/100
> > ata_acpi_exec_tfs: call get_GTF, ix=0
> > ata_acpi_exec_tfs: call set_taskfiles, ix=0
> > do_drive_set_taskfiles: unexpected GTF length (-271707516)
>
> Ugh. So the ACPI taskfile data looks like crap??
> I guess that I'll just invalidate gtf_address (set to NULL)
> if gtf_length looks invalid. Is there something better to do?
Bugger me, I'm totally acpi ignorant. But did you see my note that if I
clear gtf_address before calling into the function (where you pass it by
reference), the problem goes away? That smells more like return-on-error
without setting it at all, hence kfree() blows up when passed a bogus
stack filled variable.
> Jae-hyeon,
>
> Please send me a dump of your ACPI tables (acpidump).
> 'acpidump' is at
> http://www.kernel.org/pub/linux/kernel/people/lenb/acpi/utils/ .
> Use the latest pmtools tarball.
I've attached mine as well, in case they are useful.
> Jens, could you see that <gtf_address> your system is
> getting that is invalid?
Sure, will reboot it after posting this message.
--
Jens Axboe
[-- Attachment #2: acpi.tables.bz2 --]
[-- Type: application/x-bunzip2, Size: 58667 bytes --]
next prev parent reply other threads:[~2006-01-03 20:04 UTC|newest]
Thread overview: 27+ messages / expand[flat|nested] mbox.gz Atom feed top
2005-12-27 23:34 [PATCH 0/5] SATA/ACPI suspend/resume support Randy Dunlap
2005-12-30 8:36 ` Jae-hyeon Park
2006-01-03 17:08 ` Randy Dunlap
2006-01-03 17:26 ` Jens Axboe
2006-01-03 19:03 ` Jens Axboe
2006-01-03 19:06 ` Randy Dunlap
2006-01-03 19:57 ` Randy Dunlap
2006-01-03 20:06 ` Jens Axboe [this message]
2006-01-03 20:11 ` Randy Dunlap
2006-01-03 20:13 ` Jens Axboe
2006-01-03 21:00 ` Randy Dunlap
2006-01-03 21:16 ` Jens Axboe
2006-01-03 22:02 ` Randy Dunlap
2006-01-04 7:36 ` Jens Axboe
2006-01-03 22:40 ` Jae-hyeon Park
2006-01-04 0:40 ` Randy Dunlap
2006-01-04 1:31 ` Jae-hyeon Park
2006-01-04 18:13 ` Randy Dunlap
2006-01-04 18:57 ` Randy Dunlap
2006-01-04 19:42 ` Randy Dunlap
2006-01-05 14:08 ` Jae-hyeon Park
2006-01-05 18:36 ` Randy Dunlap
2006-01-06 1:02 ` Jae-hyeon Park
2006-01-06 1:10 ` Randy Dunlap
2006-01-06 20:43 ` Randy Dunlap
2006-01-07 13:11 ` Jae-hyeon Park
2006-01-07 16:55 ` Randy.Dunlap
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20060103200603.GA3472@suse.de \
--to=axboe@suse.de \
--cc=chris@powerblogs.com \
--cc=jgarzik@pobox.com \
--cc=jhpark@tuhep.phys.tohoku.ac.jp \
--cc=linux-ide@vger.kernel.org \
--cc=randy_d_dunlap@linux.intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).