From mboxrd@z Thu Jan 1 00:00:00 1970 From: Jens Axboe Subject: Re: [PATCH 0/5] SATA/ACPI suspend/resume support Date: Tue, 3 Jan 2006 21:13:12 +0100 Message-ID: <20060103201312.GB3472@suse.de> References: <20051227153428.4eaad244.randy_d_dunlap@linux.intel.com> <87vex7rnfn.fsf@marrow.phys.tohoku.ac.jp> <20060103090847.43c2a00d.randy_d_dunlap@linux.intel.com> <20060103172649.GV2772@suse.de> <20060103190346.GY2772@suse.de> <20060103115712.5ac7ec47.randy_d_dunlap@linux.intel.com> <20060103200603.GA3472@suse.de> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Return-path: Received: from ns.virtualhost.dk ([195.184.98.160]:29787 "EHLO virtualhost.dk") by vger.kernel.org with ESMTP id S932517AbWACUL3 (ORCPT ); Tue, 3 Jan 2006 15:11:29 -0500 Content-Disposition: inline In-Reply-To: <20060103200603.GA3472@suse.de> Sender: linux-ide-owner@vger.kernel.org List-Id: linux-ide@vger.kernel.org To: Randy Dunlap Cc: jhpark@tuhep.phys.tohoku.ac.jp, linux-ide@vger.kernel.org, jgarzik@pobox.com, chris@powerblogs.com On Tue, Jan 03 2006, Jens Axboe wrote: > On Tue, Jan 03 2006, Randy Dunlap wrote: > > > ata1: SATA max UDMA/133 cmd 0x1F0 ctl 0x3F6 bmdma 0x18C0 irq 14 > > > ata1: dev 0 cfg 49:2f00 82:346b 83:7d09 84:6003 85:3469 86:3c09 87:6003 > > > 88:203f > > > ata1: dev 0 ATA-7, max UDMA/100, 156301488 sectors: LBA48 > > > ata1(0): applying bridge limits > > > ata1: dev 0 configured for UDMA/100 > > > ata_acpi_exec_tfs: call get_GTF, ix=0 > > > ata_acpi_exec_tfs: call set_taskfiles, ix=0 > > > do_drive_set_taskfiles: unexpected GTF length (-271707516) > > > > Ugh. So the ACPI taskfile data looks like crap?? > > I guess that I'll just invalidate gtf_address (set to NULL) > > if gtf_length looks invalid. Is there something better to do? > > Bugger me, I'm totally acpi ignorant. But did you see my note that if I > clear gtf_address before calling into the function (where you pass it by > reference), the problem goes away? That smells more like return-on-error > without setting it at all, hence kfree() blows up when passed a bogus > stack filled variable. > > > Jae-hyeon, > > > > Please send me a dump of your ACPI tables (acpidump). > > 'acpidump' is at > > http://www.kernel.org/pub/linux/kernel/people/lenb/acpi/utils/ . > > Use the latest pmtools tarball. > > I've attached mine as well, in case they are useful. > > > Jens, could you see that your system is > > getting that is invalid? > > Sure, will reboot it after posting this message. It's just 0 (because I fill it as such). do_drive_get_GTF() looks suspicious, at least with noacpi != 0 it will return success without filling gtf_address. Perhaps you want to treat that as an error, or check for it earlier? Anyways, I'm pretty sure do_drive_get_GTF() needs some fixing. I'll leave that to you, let me know if you want me to test anything. -- Jens Axboe