Re: [PATCH 1/4] SATA ACPI build (applies to 2.6.16-git9)

[Jens Axboe <axboe@suse.de>]

On Mon, Jan 16 2006, Erik Mouw wrote:
> On Mon, Jan 16, 2006 at 12:56:07PM +0100, Erik Mouw wrote:
> > On Fri, Jan 13, 2006 at 10:42:52PM -0800, Randy.Dunlap wrote:
> > > --- linux-2615-g9.orig/drivers/scsi/Kconfig
> > > +++ linux-2615-g9/drivers/scsi/Kconfig
> > > @@ -599,6 +599,11 @@ config SCSI_SATA_INTEL_COMBINED
> > >  	depends on IDE=y && !BLK_DEV_IDE_SATA && (SCSI_SATA_AHCI || SCSI_ATA_PIIX)
> > >  	default y
> > >  
> > > +config SCSI_SATA_ACPI
> > > +	bool
> > > +	depends on SCSI_SATA && ACPI
> > > +	default y
> > > +
> > 
> > Could you add some help text over here? At first glance I got the
> > impression this was a host driver that works through ACPI calls, but by
> > reading the rest of your patches it turns out it is a suspend/resume
> > helper.
> 
> Something like this should already be enough:
> 
>   This option enables support for SATA suspend/resume using ACPI.
> 
> If you really need this enabled to be able to use suspend/resume at
> all, you could add a line like:
> 
>   It's safe to say Y. If you say N, you might get serious disk
>   corruption when you suspend your machine.

That's simply not true. If you say N (if you could), you could risk
having a non-responsive disk after resume. However, it would have been
synced a suspend time so you wont corrupt anything.

Maybe you don't know what the patch actually does. The main
suspend/resume support is in libata, all this adds is the ability to
retrieve the taskfiles that the BIOS/acpi thinks should be issued on
resume. That may be things like security unlocking the drive. There are
no data consistency issues involved.

-- 
Jens Axboe