From: Tejun Heo <htejun@gmail.com>
To: Jeff Garzik <jgarzik@pobox.com>, linux-ide@vger.kernel.org
Subject: [PATCH] libata: don't do EDD handling if ->probe_reset is used
Date: Sun, 12 Feb 2006 23:22:37 +0900 [thread overview]
Message-ID: <20060212142237.GA7281@htj.dyndns.org> (raw)
EDD is never used with ->probe_reset. Don't handle EDD special case
in ata_dev_identify if ->probe_reset is in use.
Signed-off-by: Tejun Heo <htejun@gmail.com>
---
This patch should have been included in the reset patchset but was
left out somehow, sorry. This patch is generated on top of "misc
preps for configuration reorganization" patchset[1] I've just posted
but also applies over upstream with offset.
[1] http://article.gmane.org/gmane.linux.ide/7977
libata-core.c | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
Index: work1/drivers/scsi/libata-core.c
===================================================================
--- work1.orig/drivers/scsi/libata-core.c 2006-02-12 22:54:42.000000000 +0900
+++ work1/drivers/scsi/libata-core.c 2006-02-12 22:56:29.000000000 +0900
@@ -939,7 +939,8 @@ static void ata_dev_identify(struct ata_
return;
}
- if (ap->flags & (ATA_FLAG_SRST | ATA_FLAG_SATA_RESET))
+ if (ap->ops->probe_reset ||
+ ap->flags & (ATA_FLAG_SRST | ATA_FLAG_SATA_RESET))
using_edd = 0;
else
using_edd = 1;
next reply other threads:[~2006-02-12 14:23 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-02-12 14:22 Tejun Heo [this message]
2006-02-12 19:29 ` [PATCH] libata: don't do EDD handling if ->probe_reset is used Jeff Garzik
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20060212142237.GA7281@htj.dyndns.org \
--to=htejun@gmail.com \
--cc=jgarzik@pobox.com \
--cc=linux-ide@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).