From mboxrd@z Thu Jan 1 00:00:00 1970 From: Sander Subject: Re: [PATCH] 2.6.xx: sata_mv: another critical fix Date: Wed, 22 Mar 2006 06:48:20 +0100 Message-ID: <20060322054820.GA5081@favonius> References: <442004E4.7010002@rtr.ca> <20060321153708.GA11703@favonius> <20060321191547.GC20426@favonius> <20060321204435.GE25066@favonius> <44206B81.1030309@garzik.org> <44207210.9080903@garzik.org> Reply-To: sander@humilis.net Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Return-path: Received: from ookhoi.xs4all.nl ([213.84.114.66]:42429 "EHLO favonius.humilis.net") by vger.kernel.org with ESMTP id S1750784AbWCVFsX (ORCPT ); Wed, 22 Mar 2006 00:48:23 -0500 Content-Disposition: inline In-Reply-To: <44207210.9080903@garzik.org> Sender: linux-ide-owner@vger.kernel.org List-Id: linux-ide@vger.kernel.org To: Jeff Garzik Cc: Linus Torvalds , Sander , Mark Lord , Mark Lord , Andrew Morton , "linux-ide@vger.kernel.org" , Linux Kernel Jeff Garzik wrote (ao): > Linus Torvalds wrote: > >Maybe back-porting any critical sata_mv fixes to 2.6.16.x is appropriate, > >considering that I don't think RH or SuSE will necessarily want to pull > >the whole thing. I'll try the 2.6.16-git3 snapshot. > Agreed -- in theory -- but I'll let Mark Lord or somebody else do that, > if they are motivated. sata_mv is labelled "HIGHLY EXPERIMENTAL" for a > reason :) Its a known bug report generator, with bugs far outpacing > fixes at present. > > Key patches to backport or test, in priority order, would be: > > [libata sata_mv] do not enable PCI MSI by default Is this in -rc6-mm2 already? Because just for fun I enabled CONFIG_PCI_MSI=y in my -rc6-mm2 .config and it still is rock stable. > After that, you're at the mercy of not-yet-worked-around hardware bugs, > and (as Mark Lord appears to be finding) some driver bugs as well. > > sata_mv development slowed to a trickle for a long time, after the > original developer disappeared, and I didn't have time to dig deep into > the hardware details. Mark Lord recently started picking up the pieces, > so things are looking much better already. I have another patch from > Mark to forward to you and 2.6.16.x (stable@), coming to you today. Things indeed look much, much better. I'll try and find some more serious fs tests and hit -rc6-mm2. Thank you all for your work on this driver! I'll order two more of these fine controllers. Sander -- Humilis IT Services and Solutions http://www.humilis.net